tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

FIX Allow clearing lazyloaded SearchableDropdownField. (#11324)

Browse Source
This commit is contained in:
Guy Sartorelli 2024-08-06 15:35:36 +12:00 committed by GitHub
parent a8d0d1ef58
commit 9fae48bbd7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Forms/SearchableDropdownTrait.php
View File

@ -29,7 +29,7 @@ trait SearchableDropdownTrait
'search', 'search',
]; ];
private bool $isClearable = false; private bool $isClearable = true;
private bool $isLazyLoaded = false; private bool $isLazyLoaded = false;

1
src/Forms/SearchableMultiDropdownField.php
View File

@ -24,6 +24,5 @@ class SearchableMultiDropdownField extends MultiSelectField
$this->setLabelField($labelField); $this->setLabelField($labelField);
$this->addExtraClass('ss-searchable-dropdown-field'); $this->addExtraClass('ss-searchable-dropdown-field');
$this->setIsMultiple(true); $this->setIsMultiple(true);
$this->setIsClearable(true);
} }
} }

6
tests/php/Forms/SearchableDropdownTraitTest.php
View File

@ -205,16 +205,16 @@ class SearchableDropdownTraitTest extends SapphireTest
$field->setForm($form); $field->setForm($form);
$schema = $field->getSchemaDataDefaults(); $schema = $field->getSchemaDataDefaults();
$this->assertFalse($schema['lazyLoad']); $this->assertFalse($schema['lazyLoad']);
$this->assertFalse($schema['clearable']); $this->assertTrue($schema['clearable']);
$this->assertSame('Select or type to search...', $schema['placeholder']); $this->assertSame('Select or type to search...', $schema['placeholder']);
$this->assertTrue($schema['searchable']); $this->assertTrue($schema['searchable']);
$field->setIsLazyLoaded(true); $field->setIsLazyLoaded(true);
$field->setIsClearable(true); $field->setIsClearable(false);
$field->setPlaceholder('My placeholder'); $field->setPlaceholder('My placeholder');
$field->setIsSearchable(false); $field->setIsSearchable(false);
$schema = $field->getSchemaDataDefaults(); $schema = $field->getSchemaDataDefaults();
$this->assertTrue($schema['lazyLoad']); $this->assertTrue($schema['lazyLoad']);
$this->assertTrue($schema['clearable']); $this->assertFalse($schema['clearable']);
$this->assertSame('My placeholder', $schema['placeholder']); $this->assertSame('My placeholder', $schema['placeholder']);
$this->assertFalse($schema['searchable']); $this->assertFalse($schema['searchable']);
} }