tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-09-14 13:36:27 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #10477 from creative-commoners/pulls/5/remove-accidental-deprecation-warnings

Browse Source 
FIX Remove accidental deprecation warnings.
This commit is contained in:
Maxime Rainville 2022-08-31 14:02:51 +12:00 committed by GitHub
commit 9f32b4b284
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
9 changed files with 0 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Core/Manifest/ClassLoader.php
View File

@ -123,10 +123,6 @@ class ClassLoader
*/
public function init($includeTests = false, $forceRegen = false)
{
if (!empty($ignoredCIConfigs)) {
Deprecation::notice('5.0.0', 'The $ignoredCIConfigs parameter will be removed in CMS 5');
}
foreach ($this->manifests as $manifest) {
/** @var ClassManifest $instance */
$instance = $manifest['instance'];

9
src/Core/Manifest/ClassManifest.php
View File

@ -11,7 +11,6 @@ use PhpParser\ParserFactory;
use PhpParser\ErrorHandler\ErrorHandler;
use Psr\SimpleCache\CacheInterface;
use SilverStripe\Core\Cache\CacheFactory;
use SilverStripe\Dev\Deprecation;
use SilverStripe\Dev\TestOnly;
/**
@ -280,10 +279,6 @@ class ClassManifest
*/
public function init($includeTests = false, $forceRegen = false)
{
if (!empty($ignoredCIConfigs)) {
Deprecation::notice('5.0.0', 'The $ignoredCIConfigs parameter will be removed in CMS 5');
}
$this->cache = $this->buildCache($includeTests);
// Check if cache is safe to use
@ -546,10 +541,6 @@ class ClassManifest
*/
public function regenerate($includeTests)
{
if (!empty($ignoredCIConfigs)) {
Deprecation::notice('5.0.0', 'The $ignoredCIConfigs parameter will be removed in CMS 5');
}
// Reset the manifest so stale info doesn't cause errors.
$this->loadState([]);
$this->roots = [];

6
src/Core/Manifest/ModuleLoader.php
View File

@ -2,8 +2,6 @@
namespace SilverStripe\Core\Manifest;
use SilverStripe\Dev\Deprecation;
/**
* Module manifest holder
*/
@ -96,10 +94,6 @@ class ModuleLoader
*/
public function init($includeTests = false, $forceRegen = false)
{
if (!empty($ignoredCIConfigs)) {
Deprecation::notice('5.0.0', 'The $ignoredCIConfigs parameter will be removed in CMS 5');
}
foreach ($this->manifests as $manifest) {
$manifest->init($includeTests, $forceRegen);
}

9
src/Core/Manifest/ModuleManifest.php
View File

@ -7,7 +7,6 @@ use Psr\SimpleCache\CacheInterface;
use SilverStripe\Core\Cache\CacheFactory;
use SilverStripe\Core\Config\Configurable;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\Deprecation;
/**
* A utility class which builds a manifest of configuration items
@ -125,10 +124,6 @@ class ModuleManifest
*/
public function init($includeTests = false, $forceRegen = false)
{
if (!empty($ignoredCIConfigs)) {
Deprecation::notice('5.0.0', 'The $ignoredCIConfigs parameter will be removed in CMS 5');
}
// build cache from factory
if ($this->cacheFactory) {
$this->cache = $this->cacheFactory->create(
@ -170,10 +165,6 @@ class ModuleManifest
*/
public function regenerate($includeTests = false)
{
if (!empty($ignoredCIConfigs)) {
Deprecation::notice('5.0.0', 'The $ignoredCIConfigs parameter will be removed in CMS 5');
}
$this->modules = [];
$finder = new ManifestFileFinder();

3
src/Dev/Constraint/SSListContains.php
View File

@ -4,7 +4,6 @@ namespace SilverStripe\Dev\Constraint;
use PHPUnit\Framework\Constraint\Constraint;
use PHPUnit\Framework\ExpectationFailedException;
use SilverStripe\Dev\Deprecation;
use SilverStripe\Dev\SSListExporter;
use SilverStripe\Dev\TestOnly;
use SilverStripe\ORM\SS_List;
@ -30,8 +29,6 @@ class SSListContains extends Constraint implements TestOnly
public function __construct(array $matches)
{
Deprecation::notice('5.0.0', 'This class will be removed in CMS 5', Deprecation::SCOPE_CLASS);
$this->exporter = new SSListExporter();
$this->matches = $matches;

2
src/Dev/Constraint/SSListContainsOnlyMatchingItems.php
View File

@ -4,7 +4,6 @@ namespace SilverStripe\Dev\Constraint;
use PHPUnit\Framework\Constraint\Constraint;
use PHPUnit\Framework\ExpectationFailedException;
use SilverStripe\Dev\Deprecation;
use SilverStripe\Dev\SSListExporter;
use SilverStripe\Dev\TestOnly;
use SilverStripe\ORM\SS_List;
@ -27,7 +26,6 @@ class SSListContainsOnlyMatchingItems extends Constraint implements TestOnly
public function __construct($match)
{
Deprecation::notice('5.0.0', 'This class will be removed in CMS 5', Deprecation::SCOPE_CLASS);
$this->exporter = new SSListExporter();
$this->constraint = new ViewableDataContains($match);

2
src/Dev/FunctionalTest.php
View File

@ -83,8 +83,6 @@ abstract class FunctionalTest extends SapphireTest implements TestOnly
protected function setUp(): void
{
Deprecation::notice('5.0.0', 'This class will be removed in CMS 5', Deprecation::SCOPE_CLASS);
parent::setUp();
// Skip calling FunctionalTest directly.

2
src/Dev/SapphireTest.php
View File

@ -264,8 +264,6 @@ abstract class SapphireTest extends TestCase implements TestOnly
*/
protected function setUp(): void
{
Deprecation::notice('5.0.0', 'This class will be removed in CMS 5', Deprecation::SCOPE_CLASS);
if (!defined('FRAMEWORK_PATH')) {
trigger_error(
'Missing constants, did you remember to include the test bootstrap in your phpunit.xml file?',

9
src/View/ThemeManifest.php
View File

@ -6,7 +6,6 @@ use Psr\SimpleCache\CacheInterface;
use SilverStripe\Core\Cache\CacheFactory;
use SilverStripe\Core\Manifest\ManifestFileFinder;
use SilverStripe\Core\Manifest\ModuleLoader;
use SilverStripe\Dev\Deprecation;
/**
* A class which builds a manifest of all themes (which is really just a directory called "templates")
@ -77,10 +76,6 @@ class ThemeManifest implements ThemeList
*/
public function init($includeTests = false, $forceRegen = false)
{
if (!empty($ignoredCIConfigs)) {
Deprecation::notice('5.0.0', 'The $ignoredCIConfigs parameter will be removed in CMS 5');
}
// build cache from factory
if ($this->cacheFactory) {
$this->cache = $this->cacheFactory->create(
@ -137,10 +132,6 @@ class ThemeManifest implements ThemeList
*/
public function regenerate($includeTests = false)
{
if (!empty($ignoredCIConfigs)) {
Deprecation::notice('5.0.0', 'The $ignoredCIConfigs parameter will be removed in CMS 5');
}
$finder = new ManifestFileFinder();
$finder->setOptions([
'include_themes' => false,