tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

FIX Table aliases are retained on base tables in queries built using SQLConditionalExpression (#8918)

Browse Source 
* Adding failing test for base table aliases using SQLSelect

* FIX Retain table aliases applied to the base table on queries

* FIX Move the trimmed alias outside of the condition so we can use it within the condition
This commit is contained in:
Guy Marriott 2019-04-16 15:40:09 +12:00 committed by Aaron Carlino
parent be9f0120ad
commit 9d6b5048a6
2 changed files with 47 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/ORM/Queries/SQLConditionalExpression.php
View File

@ -283,6 +283,16 @@ abstract class SQLConditionalExpression extends SQLExpression
// array('type' => 'inner', 'table' => 'SiteTree', 'filter' => array("SiteTree.ID = 1", // array('type' => 'inner', 'table' => 'SiteTree', 'filter' => array("SiteTree.ID = 1",
// "Status = 'approved'", 'order' => 20)) // "Status = 'approved'", 'order' => 20))
if (!is_array($join)) { if (!is_array($join)) {
if (empty($alias) || is_numeric($alias)) {
continue;
}
$trimmedAlias = trim($alias, '"');
if ($trimmedAlias !== trim($join, '"')) {
$joins[$alias] = "{$join} AS \"{$trimmedAlias}\"";
}
continue; continue;
} }
@ -321,8 +331,15 @@ abstract class SQLConditionalExpression extends SQLExpression
*/ */
protected function getOrderedJoins($from) protected function getOrderedJoins($from)
{ {
if (count($from) <= 1) {
return $from;
}
// shift the first FROM table out from so we only deal with the JOINs // shift the first FROM table out from so we only deal with the JOINs
reset($from);
$baseFromAlias = key($from);
$baseFrom = array_shift($from); $baseFrom = array_shift($from);
$this->mergesort($from, function ($firstJoin, $secondJoin) { $this->mergesort($from, function ($firstJoin, $secondJoin) {
if (!is_array($firstJoin) if (!is_array($firstJoin)
|| !is_array($secondJoin) || !is_array($secondJoin)
@ -335,7 +352,12 @@ abstract class SQLConditionalExpression extends SQLExpression
}); });
// Put the first FROM table back into the results // Put the first FROM table back into the results
array_unshift($from, $baseFrom); if (!empty($baseFromAlias) && !is_numeric($baseFromAlias)) {
$from = array_merge([$baseFromAlias => $baseFrom], $from);
} else {
array_unshift($from, $baseFrom);
}
return $from; return $from;
} }

24
tests/php/ORM/SQLSelectTest.php
View File

@ -823,4 +823,28 @@ class SQLSelectTest extends SapphireTest
$this->assertEquals(array('%MyName%', '2012-08-08 12:00'), $parameters); $this->assertEquals(array('%MyName%', '2012-08-08 12:00'), $parameters);
$query->execute(); $query->execute();
} }
public function testBaseTableAliases()
{
$query = SQLSelect::create('*', ['"MyTableAlias"' => '"MyTable"']);
$sql = $query->sql();
$this->assertSQLEquals('SELECT * FROM "MyTable" AS "MyTableAlias"', $sql);
$query = SQLSelect::create('*', ['MyTableAlias' => '"MyTable"']);
$sql = $query->sql();
$this->assertSQLEquals('SELECT * FROM "MyTable" AS "MyTableAlias"', $sql);
$query = SQLSelect::create('*', ['"MyTableAlias"' => '"MyTable"']);
$query->addLeftJoin('OtherTable', '"Thing" = "OtherThing"', 'OtherTableAlias');
$sql = $query->sql();
$this->assertSQLEquals(
'SELECT *
FROM "MyTable" AS "MyTableAlias"
LEFT JOIN "OtherTable" AS "OtherTableAlias" ON "Thing" = "OtherThing"',
$sql
);
}
} }