diff --git a/docs/en/05_Contributing/09_Core_committers.md b/docs/en/05_Contributing/09_Core_committers.md index 39cf92641..b0b5f679d 100644 --- a/docs/en/05_Contributing/09_Core_committers.md +++ b/docs/en/05_Contributing/09_Core_committers.md @@ -51,9 +51,18 @@ With great power comes great responsibility, so we have agreed on certain expect * Use your own forks to create feature branches * We release using the standard process. See the [Making a SilverStripe Core Release](making_a_silverstripe_core_release) -## Contributing Committers +## Roles -Beyond the group of Core Committers, there can be individuals which +### Core Committer + +Core Committers should have at least "Maintain" level access to Silverstripe Core, +which includes the ability to push changes and perform releases. + +This role may be granted by a quorum of all Core Committers. + +### Contributing Committers + +Beyond the Core Committer role, there can be individuals which focus on core development work - typically sponsored through full-time product development roles by SilverStripe Ltd. These Contributing Committers require write access to core repositories to maintain their pace, often working alongside Core Committers. They are guided by additional rules: @@ -64,6 +73,18 @@ often working alongside Core Committers. They are guided by additional rules: * More straightforward changes (e.g. documentation, styling) or areas which require quite specialised expertise (e.g. React) that's less available through most Core Committers can be approved or merged by team members who aren't Core Committers * Self-merges should be avoided, but are preferable to having work go stale or forcing other team members to waste time by context switching into a complex review (e.g. because the original reviewer went on leave). Any self-merge should be accompanied by a comment why this couldn't be handled in another way, and a (preferably written) approval from another team member. +This role may be granted by any Core Committer, +who should give other Core Committers an opportunity to weigh in on the decision. + +### Triage + +Triage of issues and pull request is an important activity: Reviewing issues, adding labels, +closing stale issues, etc. This does not require write access to the repository as a "Contributing Committer". +This is a great way for active community members to help out, and start a path towards becoming a Core Committer. + +Triage roles may be granted by any Core Committer, +who should give other Core Committers an opportunity to weigh in on the decision. + ## Supported Modules In addition to Silverstripe Core, there are many [Supported Modules](https://www.silverstripe.org/software/addons/supported-modules-definition/)