From 98afbfe9b4cc5c043920f6a7c906cd2fc584adde Mon Sep 17 00:00:00 2001
From: Maxime Rainville <maxime@silverstripe.com>
Date: Thu, 11 Oct 2018 14:56:06 +1300
Subject: [PATCH] Implement Peer review feedback #8460

---
 src/Forms/GridField/GridFieldLazyLoader.php | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/src/Forms/GridField/GridFieldLazyLoader.php b/src/Forms/GridField/GridFieldLazyLoader.php
index ac1881b5a..63a761f6e 100755
--- a/src/Forms/GridField/GridFieldLazyLoader.php
+++ b/src/Forms/GridField/GridFieldLazyLoader.php
@@ -6,7 +6,6 @@ use SilverStripe\Forms\FormField;
 use SilverStripe\Forms\TabSet;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\Filterable;
-use SilverStripe\ORM\Limitable;
 use SilverStripe\ORM\SS_List;
 
 /**
@@ -19,7 +18,11 @@ class GridFieldLazyLoader implements GridField_DataManipulator, GridField_HTMLPr
 {
 
     /**
-     * @inheritDoc
+     * Empty $datalist if the current request should be lazy loadable.
+     *
+     * @param GridField $gridField
+     * @param SS_List $dataList
+     * @return SS_List
      */
     public function getManipulatedData(GridField $gridField, SS_List $dataList)
     {
@@ -37,13 +40,16 @@ class GridFieldLazyLoader implements GridField_DataManipulator, GridField_HTMLPr
     }
 
     /**
-     * @inheritDoc
+     * Apply an appropriate CSS class to `$gridField` based on whatever the current request is lazy loadable or not.
+     *
+     * @param GridField $gridField
+     * @return array
      */
     public function getHTMLFragments($gridField)
     {
         $gridField->addExtraClass($this->isLazy($gridField) ?
-            'grid-field-lazy-loadable' :
-            'grid-field-lazy-loaded');
+            'grid-field--lazy-loadable' :
+            'grid-field--lazy-loaded');
         return [];
     }
 
@@ -71,8 +77,8 @@ class GridFieldLazyLoader implements GridField_DataManipulator, GridField_HTMLPr
             // Classes that extends TabSet might not have the expected JS to lazy load.
             return get_class($containerField) === TabSet::class
                 ?: $this->isInTabSet($containerField);
-        } else {
-            return false;
         }
+
+        return false;
     }
 }