tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

MINOR: faster checking if record exists

Browse Source 
Rather than using a loop through each object, we just filter for it in the SQL query.  This is likely to speed up the code and also make it more legible.
This commit is contained in:
Nicolaas / Sunny Side Up 2023-04-28 09:40:12 +12:00 committed by GitHub
parent 73ef035bd8
commit 9660652fbc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Security/Member.php
View File

@ -924,15 +924,8 @@ class Member extends DataObject
}
$groupCandidateObjs = ($strict) ? $this->getManyManyComponents("Groups") : $this->Groups();
if ($groupCandidateObjs) {
foreach ($groupCandidateObjs as $groupCandidateObj) {
if ($groupCandidateObj->ID == $groupCheckObj->ID) {
return true;
}
}
}
return false;
return $groupCandidateObjs->filter(['ID' => $groupCheckObj->ID])->exists();
}
/**