From 94d6b1ccff6d2c3f3060432f0cdef7ffa307b9ce Mon Sep 17 00:00:00 2001 From: Will Rossiter Date: Fri, 10 May 2013 20:32:59 +1200 Subject: [PATCH] FIX: Disable autocomplete on ConfirmedPasswordField instances. --- forms/ConfirmedPasswordField.php | 8 ++++++++ javascript/ConfirmedPasswordField.js | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/forms/ConfirmedPasswordField.php b/forms/ConfirmedPasswordField.php index f04337bd6..58e2681a4 100644 --- a/forms/ConfirmedPasswordField.php +++ b/forms/ConfirmedPasswordField.php @@ -95,6 +95,12 @@ class ConfirmedPasswordField extends FormField { if($showOnClick) { $this->children->push(new HiddenField("{$name}[_PasswordFieldVisible]")); } + + // disable auto complete + foreach($this->children as $child) { + $child->setAttribute('autocomplete', 'off'); + } + $this->showOnClick = $showOnClick; // we have labels for the subfields @@ -136,11 +142,13 @@ class ConfirmedPasswordField extends FormField { foreach($this->children as $field) { $field->setDisabled($this->isDisabled()); $field->setReadonly($this->isReadonly()); + if(count($this->attributes)) { foreach($this->attributes as $name => $value) { $field->setAttribute($name, $value); } } + $content .= $field->FieldHolder(); } diff --git a/javascript/ConfirmedPasswordField.js b/javascript/ConfirmedPasswordField.js index 2036e2436..05814514a 100644 --- a/javascript/ConfirmedPasswordField.js +++ b/javascript/ConfirmedPasswordField.js @@ -1,5 +1,5 @@ (function ($) { - $('.confirmedpassword .showOnClick a').live('click', function () { + $(document).on('click', '.confirmedpassword .showOnClick a', function () { var $container = $('.showOnClickContainer', $(this).parent()); $container.toggle('fast', function() {