tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #4829 from SilbinaryWolf/manifest-optimizations-v2

Browse Source 
Optimization: Swapped is_array for faster casting compare, shaved ~4s off flushing on 3.2ghz i5 dual core system
This commit is contained in:
Daniel Hensby 2015-12-08 12:12:48 +00:00
commit 9353751131
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
core/manifest/ConfigStaticManifest.php
View File

@ -239,7 +239,7 @@ class SS_ConfigStaticManifest_Parser {
$depth = 0; $namespace = null; $class = null; $clsdepth = null; $access = 0;
while($token = $this->next()) {
$type = is_array($token) ? $token[0] : $token;
$type = ($token === (array)$token) ? $token[0] : $token;
if($type == T_CLASS) {
$next = $this->nextString();
@ -302,7 +302,7 @@ class SS_ConfigStaticManifest_Parser {
$value = '';
while($token = $this->next()) {
$type = is_array($token) ? $token[0] : $token;
$type = ($token === (array)$token) ? $token[0] : $token;
if($type == T_PUBLIC || $type == T_PRIVATE || $type == T_PROTECTED) {
$access = $type;
@ -328,8 +328,8 @@ class SS_ConfigStaticManifest_Parser {
if($token == '=') {
$depth = 0;
while($token = $this->next(false)){
$type = is_array($token) ? $token[0] : $token;
while($token = ($this->pos >= $this->length) ? null : $this->tokens[$this->pos++]) {
$type = ($token === (array)$token) ? $token[0] : $token;
// Track array nesting depth
if($type == T_ARRAY || $type == '[') {
@ -351,7 +351,7 @@ class SS_ConfigStaticManifest_Parser {
$value .= $class;
}
else {
$value .= is_array($token) ? $token[1] : $token;
$value .= ($token === (array)$token) ? $token[1] : $token;
}
}
}