NEW: Add Symfony 4 support alongside Symfony 3

- Remove duplicate key in YML file
 - Remove deprecated yaml dump indentation set (the constructor arg works in both ^3 and ^4)

Fixes #9274
This commit is contained in:
Sam Minnee 2020-09-18 17:55:31 +12:00
parent ae0ece2b02
commit 9247bc8b79
3 changed files with 6 additions and 7 deletions

View File

@ -37,10 +37,10 @@
"silverstripe/vendor-plugin": "^1.4", "silverstripe/vendor-plugin": "^1.4",
"sminnee/callbacklist": "^0.1", "sminnee/callbacklist": "^0.1",
"swiftmailer/swiftmailer": "~5.4", "swiftmailer/swiftmailer": "~5.4",
"symfony/cache": "^3.3@dev", "symfony/cache": "^3.3 || ^4",
"symfony/config": "^3.2", "symfony/config": "^3.2 || ^4",
"symfony/translation": "^2.8", "symfony/translation": "^2.8 || ^3 || ^4",
"symfony/yaml": "~3.2", "symfony/yaml": "^3.2 || ^4",
"php": ">=7.1.0", "php": ">=7.1.0",
"ext-ctype": "*", "ext-ctype": "*",
"ext-dom": "*", "ext-dom": "*",

View File

@ -29,8 +29,7 @@ class YamlWriter implements Writer
protected function getDumper() protected function getDumper()
{ {
if (!$this->dumper) { if (!$this->dumper) {
$this->dumper = new Dumper(); $this->dumper = new Dumper(2);
$this->dumper->setIndentation(2);
} }
return $this->dumper; return $this->dumper;
} }

View File

@ -143,7 +143,7 @@ SilverStripe\ORM\Tests\DataObjectTest\Company:
company1: company1:
Name: Company corp Name: Company corp
Owner: =>SilverStripe\ORM\Tests\DataObjectTest\Player.player1 Owner: =>SilverStripe\ORM\Tests\DataObjectTest\Player.player1
company1: company2:
Name: 'Team co.' Name: 'Team co.'
Owner: =>SilverStripe\ORM\Tests\DataObjectTest\Player.player2 Owner: =>SilverStripe\ORM\Tests\DataObjectTest\Player.player2
SilverStripe\ORM\Tests\DataObjectTest\Bracket: SilverStripe\ORM\Tests\DataObjectTest\Bracket: