tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

MINOR Fixed DataObjectTest to use ManyManyList when testing relation manipulations

Browse Source
This commit is contained in:
Stig Lindqvist 2011-09-27 15:01:06 +13:00 committed by Stig Lindqvist
parent 73c249128b
commit 8d7bfd4ffa
1 changed files with 49 additions and 43 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

92
tests/model/DataObjectTest.php
View File

@ -24,20 +24,17 @@ class DataObjectTest extends SapphireTest {
$obj = new DataObjectTest_SubTeam(); $obj = new DataObjectTest_SubTeam();
$obj->SubclassDatabaseField = "obj-SubTeam"; $obj->SubclassDatabaseField = "obj-SubTeam";
$obj->write(); $obj->write();
// Change the class // Change the class
$obj->ClassName = 'OtherSubclassWithSameField'; $obj->ClassName = 'OtherSubclassWithSameField';
$obj->write(); $obj->write();
$obj->flushCache(); $obj->flushCache();
// Re-fetch from the database and confirm that the data is sourced from
// Re-fetch from the database and confirm that the data is sourced from
// OtherSubclassWithSameField.SubclassDatabaseField // OtherSubclassWithSameField.SubclassDatabaseField
$obj = DataObject::get_by_id('DataObjectTest_Team', $obj->ID); $obj = DataObject::get_by_id('DataObjectTest_Team', $obj->ID);
$this->assertNull($obj->SubclassDatabaseField); $this->assertNull($obj->SubclassDatabaseField);
// Confirm that save the object in the other direction. // Confirm that save the object in the other direction.
$obj->SubclassDatabaseField = 'obj-Other'; $obj->SubclassDatabaseField = 'obj-Other';
$obj->write(); $obj->write();
@ -70,8 +67,8 @@ class DataObjectTest extends SapphireTest {
// Check that page does not exist after deleting // Check that page does not exist after deleting
$obj = DataObject::get_by_id('DataObjectTest_Player', $objID); $obj = DataObject::get_by_id('DataObjectTest_Player', $objID);
$this->assertTrue(!$obj || !$obj->exists()); $this->assertTrue(!$obj || !$obj->exists());
// Test deleting using DataObject::delete_by_id() // Test deleting using DataObject::delete_by_id()
// Get the second page // Get the second page
$obj = $this->objFromFixture('DataObjectTest_Player', 'captain2'); $obj = $this->objFromFixture('DataObjectTest_Player', 'captain2');
@ -84,7 +81,7 @@ class DataObjectTest extends SapphireTest {
$obj = DataObject::get_by_id('DataObjectTest_Player', $objID); $obj = DataObject::get_by_id('DataObjectTest_Player', $objID);
$this->assertTrue(!$obj || !$obj->exists()); $this->assertTrue(!$obj || !$obj->exists());
} }
/** /**
* Test methods that get DataObjects * Test methods that get DataObjects
* - DataObject::get() * - DataObject::get()
@ -103,14 +100,14 @@ class DataObjectTest extends SapphireTest {
// Test getting all records of a DataObject // Test getting all records of a DataObject
$comments = DataObject::get('DataObjectTest_TeamComment'); $comments = DataObject::get('DataObjectTest_TeamComment');
$this->assertEquals(3, $comments->Count()); $this->assertEquals(3, $comments->Count());
// Test WHERE clause // Test WHERE clause
$comments = DataObject::get('DataObjectTest_TeamComment', "\"Name\"='Bob'"); $comments = DataObject::get('DataObjectTest_TeamComment', "\"Name\"='Bob'");
$this->assertEquals(1, $comments->Count()); $this->assertEquals(1, $comments->Count());
foreach($comments as $comment) { foreach($comments as $comment) {
$this->assertEquals('Bob', $comment->Name); $this->assertEquals('Bob', $comment->Name);
} }
// Test sorting // Test sorting
$comments = DataObject::get('DataObjectTest_TeamComment', '', "\"Name\" ASC"); $comments = DataObject::get('DataObjectTest_TeamComment', '', "\"Name\" ASC");
$this->assertEquals(3, $comments->Count()); $this->assertEquals(3, $comments->Count());
@ -118,58 +115,58 @@ class DataObjectTest extends SapphireTest {
$comments = DataObject::get('DataObjectTest_TeamComment', '', "\"Name\" DESC"); $comments = DataObject::get('DataObjectTest_TeamComment', '', "\"Name\" DESC");
$this->assertEquals(3, $comments->Count()); $this->assertEquals(3, $comments->Count());
$this->assertEquals('Phil', $comments->First()->Name); $this->assertEquals('Phil', $comments->First()->Name);
// Test join // Test join
$comments = DataObject::get( $comments = DataObject::get(
'DataObjectTest_TeamComment', 'DataObjectTest_TeamComment',
"\"DataObjectTest_Team\".\"Title\" = 'Team 1'", "\"DataObjectTest_Team\".\"Title\" = 'Team 1'",
"\"Name\" ASC", "\"Name\" ASC",
"INNER JOIN \"DataObjectTest_Team\" ON \"DataObjectTest_TeamComment\".\"TeamID\" = \"DataObjectTest_Team\".\"ID\"" "INNER JOIN \"DataObjectTest_Team\" ON \"DataObjectTest_TeamComment\".\"TeamID\" = \"DataObjectTest_Team\".\"ID\""
); );
$this->assertEquals(2, $comments->Count()); $this->assertEquals(2, $comments->Count());
$this->assertEquals('Bob', $comments->First()->Name); $this->assertEquals('Bob', $comments->First()->Name);
$this->assertEquals('Joe', $comments->Last()->Name); $this->assertEquals('Joe', $comments->Last()->Name);
// Test limit // Test limit
$comments = DataObject::get('DataObjectTest_TeamComment', '', "\"Name\" ASC", '', '1,2'); $comments = DataObject::get('DataObjectTest_TeamComment', '', "\"Name\" ASC", '', '1,2');
$this->assertEquals(2, $comments->Count()); $this->assertEquals(2, $comments->Count());
$this->assertEquals('Joe', $comments->First()->Name); $this->assertEquals('Joe', $comments->First()->Name);
$this->assertEquals('Phil', $comments->Last()->Name); $this->assertEquals('Phil', $comments->Last()->Name);
// Test get_by_id() // Test get_by_id()
$captain1ID = $this->idFromFixture('DataObjectTest_Player', 'captain1'); $captain1ID = $this->idFromFixture('DataObjectTest_Player', 'captain1');
$captain1 = DataObject::get_by_id('DataObjectTest_Player', $captain1ID); $captain1 = DataObject::get_by_id('DataObjectTest_Player', $captain1ID);
$this->assertEquals('Captain', $captain1->FirstName); $this->assertEquals('Captain', $captain1->FirstName);
// Test get_one() without caching // Test get_one() without caching
$comment1 = DataObject::get_one('DataObjectTest_TeamComment', "\"Name\" = 'Joe'", false); $comment1 = DataObject::get_one('DataObjectTest_TeamComment', "\"Name\" = 'Joe'", false);
$comment1->Comment = "Something Else"; $comment1->Comment = "Something Else";
$comment2 = DataObject::get_one('DataObjectTest_TeamComment', "\"Name\" = 'Joe'", false); $comment2 = DataObject::get_one('DataObjectTest_TeamComment', "\"Name\" = 'Joe'", false);
$this->assertNotEquals($comment1->Comment, $comment2->Comment); $this->assertNotEquals($comment1->Comment, $comment2->Comment);
// Test get_one() with caching // Test get_one() with caching
$comment1 = DataObject::get_one('DataObjectTest_TeamComment', "\"Name\" = 'Bob'", true); $comment1 = DataObject::get_one('DataObjectTest_TeamComment', "\"Name\" = 'Bob'", true);
$comment1->Comment = "Something Else"; $comment1->Comment = "Something Else";
$comment2 = DataObject::get_one('DataObjectTest_TeamComment', "\"Name\" = 'Bob'", true); $comment2 = DataObject::get_one('DataObjectTest_TeamComment', "\"Name\" = 'Bob'", true);
$this->assertEquals((string)$comment1->Comment, (string)$comment2->Comment); $this->assertEquals((string)$comment1->Comment, (string)$comment2->Comment);
// Test get_one() with order by without caching // Test get_one() with order by without caching
$comment = DataObject::get_one('DataObjectTest_TeamComment', '', false, "\"Name\" ASC"); $comment = DataObject::get_one('DataObjectTest_TeamComment', '', false, "\"Name\" ASC");
$this->assertEquals('Bob', $comment->Name); $this->assertEquals('Bob', $comment->Name);
$comment = DataObject::get_one('DataObjectTest_TeamComment', '', false, "\"Name\" DESC"); $comment = DataObject::get_one('DataObjectTest_TeamComment', '', false, "\"Name\" DESC");
$this->assertEquals('Phil', $comment->Name); $this->assertEquals('Phil', $comment->Name);
// Test get_one() with order by with caching // Test get_one() with order by with caching
$comment = DataObject::get_one('DataObjectTest_TeamComment', '', true, '"Name" ASC'); $comment = DataObject::get_one('DataObjectTest_TeamComment', '', true, '"Name" ASC');
$this->assertEquals('Bob', $comment->Name); $this->assertEquals('Bob', $comment->Name);
$comment = DataObject::get_one('DataObjectTest_TeamComment', '', true, '"Name" DESC'); $comment = DataObject::get_one('DataObjectTest_TeamComment', '', true, '"Name" DESC');
$this->assertEquals('Phil', $comment->Name); $this->assertEquals('Phil', $comment->Name);
} }
function testGetSubclassFields() { function testGetSubclassFields() {
/* Test that fields / has_one relations from the parent table and the subclass tables are extracted */ /* Test that fields / has_one relations from the parent table and the subclass tables are extracted */
$captain1 = $this->objFromFixture("DataObjectTest_Player", "captain1"); $captain1 = $this->objFromFixture("DataObjectTest_Player", "captain1");
@ -180,7 +177,7 @@ class DataObjectTest extends SapphireTest {
// Subclass has_one relation // Subclass has_one relation
$this->assertEquals($this->idFromFixture('DataObjectTest_Team', 'team1'), $captain1->FavouriteTeamID); $this->assertEquals($this->idFromFixture('DataObjectTest_Team', 'team1'), $captain1->FavouriteTeamID);
} }
function testGetHasOneRelations() { function testGetHasOneRelations() {
$captain1 = $this->objFromFixture("DataObjectTest_Player", "captain1"); $captain1 = $this->objFromFixture("DataObjectTest_Player", "captain1");
/* There will be a field called (relname)ID that contains the ID of the object linked to via the has_one relation */ /* There will be a field called (relname)ID that contains the ID of the object linked to via the has_one relation */
@ -188,13 +185,13 @@ class DataObjectTest extends SapphireTest {
/* There will be a method called $obj->relname() that returns the object itself */ /* There will be a method called $obj->relname() that returns the object itself */
$this->assertEquals($this->idFromFixture('DataObjectTest_Team', 'team1'), $captain1->FavouriteTeam()->ID); $this->assertEquals($this->idFromFixture('DataObjectTest_Team', 'team1'), $captain1->FavouriteTeam()->ID);
} }
function testLimitAndCount() { function testLimitAndCount() {
$players = DataObject::get("DataObjectTest_Player"); $players = DataObject::get("DataObjectTest_Player");
// There's 4 records in total // There's 4 records in total
$this->assertEquals(4, $players->count()); $this->assertEquals(4, $players->count());
// Testing "## offset ##" syntax // Testing "## offset ##" syntax
$this->assertEquals(4, $players->limit("20 OFFSET 0")->count()); $this->assertEquals(4, $players->limit("20 OFFSET 0")->count());
$this->assertEquals(0, $players->limit("20 OFFSET 20")->count()); $this->assertEquals(0, $players->limit("20 OFFSET 20")->count());
@ -211,7 +208,7 @@ class DataObjectTest extends SapphireTest {
/** /**
* Test writing of database columns which don't correlate to a DBField, * Test writing of database columns which don't correlate to a DBField,
* e.g. all relation fields on has_one/has_many like "ParentID". * e.g. all relation fields on has_one/has_many like "ParentID".
* *
*/ */
function testWritePropertyWithoutDBField() { function testWritePropertyWithoutDBField() {
@ -222,7 +219,7 @@ class DataObjectTest extends SapphireTest {
$savedObj = DataObject::get_by_id('DataObjectTest_Player', $obj->ID); $savedObj = DataObject::get_by_id('DataObjectTest_Player', $obj->ID);
$this->assertTrue($savedObj->FavouriteTeamID == 99); $this->assertTrue($savedObj->FavouriteTeamID == 99);
} }
/** /**
* Test has many relationships * Test has many relationships
* - Test getComponents() gets the ComponentSet of the other side of the relation * - Test getComponents() gets the ComponentSet of the other side of the relation
@ -230,15 +227,15 @@ class DataObjectTest extends SapphireTest {
*/ */
function testHasManyRelationships() { function testHasManyRelationships() {
$team = $this->objFromFixture('DataObjectTest_Team', 'team1'); $team = $this->objFromFixture('DataObjectTest_Team', 'team1');
// Test getComponents() gets the ComponentSet of the other side of the relation // Test getComponents() gets the ComponentSet of the other side of the relation
$this->assertTrue($team->Comments()->Count() == 2); $this->assertTrue($team->Comments()->Count() == 2);
// Test the IDs on the DataObjects are set correctly // Test the IDs on the DataObjects are set correctly
foreach($team->Comments() as $comment) { foreach($team->Comments() as $comment) {
$this->assertEquals($team->ID, $comment->TeamID); $this->assertEquals($team->ID, $comment->TeamID);
} }
// Test that we can add and remove items that already exist in the database // Test that we can add and remove items that already exist in the database
$newComment = new DataObjectTest_TeamComment(); $newComment = new DataObjectTest_TeamComment();
$newComment->Name = "Automated commenter"; $newComment->Name = "Automated commenter";
@ -246,7 +243,7 @@ class DataObjectTest extends SapphireTest {
$newComment->write(); $newComment->write();
$team->Comments()->add($newComment); $team->Comments()->add($newComment);
$this->assertEquals($team->ID, $newComment->TeamID); $this->assertEquals($team->ID, $newComment->TeamID);
$comment1 = $this->fixture->objFromFixture('DataObjectTest_TeamComment', 'comment1'); $comment1 = $this->fixture->objFromFixture('DataObjectTest_TeamComment', 'comment1');
$comment2 = $this->fixture->objFromFixture('DataObjectTest_TeamComment', 'comment2'); $comment2 = $this->fixture->objFromFixture('DataObjectTest_TeamComment', 'comment2');
$team->Comments()->remove($comment2); $team->Comments()->remove($comment2);
@ -258,11 +255,11 @@ class DataObjectTest extends SapphireTest {
function testHasOneRelationship() { function testHasOneRelationship() {
$team1 = $this->objFromFixture('DataObjectTest_Team', 'team1'); $team1 = $this->objFromFixture('DataObjectTest_Team', 'team1');
$player1 = $this->objFromFixture('DataObjectTest_Player', 'player1'); $player1 = $this->objFromFixture('DataObjectTest_Player', 'player1');
// Add a captain to team 1 // Add a captain to team 1
$team1->setField('CaptainID', $player1->ID); $team1->setField('CaptainID', $player1->ID);
$team1->write(); $team1->write();
$this->assertEquals($player1->ID, $team1->Captain()->ID, 'The captain exists for team 1'); $this->assertEquals($player1->ID, $team1->Captain()->ID, 'The captain exists for team 1');
$this->assertEquals($player1->ID, $team1->getComponent('Captain')->ID, 'The captain exists through the component getter'); $this->assertEquals($player1->ID, $team1->getComponent('Captain')->ID, 'The captain exists through the component getter');
@ -282,7 +279,10 @@ class DataObjectTest extends SapphireTest {
// Test adding single DataObject by reference // Test adding single DataObject by reference
$player1->Teams()->add($team1); $player1->Teams()->add($team1);
$player1->flushCache(); $player1->flushCache();
$compareTeams = new ManyManyList($team1);
$compareTeams = new ManyManyList('DataObjectTest_Team','DataObjectTest_Team_Players', 'DataObjectTest_TeamID', 'DataObjectTest_PlayerID');
$compareTeams->forForeignID($player1->ID);
$compareTeams->byID($team1->ID);
$this->assertEquals( $this->assertEquals(
$player1->Teams()->column('ID'), $player1->Teams()->column('ID'),
$compareTeams->column('ID'), $compareTeams->column('ID'),
@ -292,7 +292,9 @@ class DataObjectTest extends SapphireTest {
// test removing single DataObject by reference // test removing single DataObject by reference
$player1->Teams()->remove($team1); $player1->Teams()->remove($team1);
$player1->flushCache(); $player1->flushCache();
$compareTeams = new ManyManyList(); $compareTeams = new ManyManyList('DataObjectTest_Team','DataObjectTest_Team_Players', 'DataObjectTest_TeamID', 'DataObjectTest_PlayerID');
$compareTeams->forForeignID($player1->ID);
$compareTeams->byID($team1->ID);
$this->assertEquals( $this->assertEquals(
$player1->Teams()->column('ID'), $player1->Teams()->column('ID'),
$compareTeams->column('ID'), $compareTeams->column('ID'),
@ -302,7 +304,9 @@ class DataObjectTest extends SapphireTest {
// test adding single DataObject by ID // test adding single DataObject by ID
$player1->Teams()->add($team1->ID); $player1->Teams()->add($team1->ID);
$player1->flushCache(); $player1->flushCache();
$compareTeams = new ManyManyList($team1); $compareTeams = new ManyManyList('DataObjectTest_Team','DataObjectTest_Team_Players', 'DataObjectTest_TeamID', 'DataObjectTest_PlayerID');
$compareTeams->forForeignID($player1->ID);
$compareTeams->byID($team1->ID);
$this->assertEquals( $this->assertEquals(
$player1->Teams()->column('ID'), $player1->Teams()->column('ID'),
$compareTeams->column('ID'), $compareTeams->column('ID'),
@ -312,7 +316,9 @@ class DataObjectTest extends SapphireTest {
// test removing single DataObject by ID // test removing single DataObject by ID
$player1->Teams()->removeByID($team1->ID); $player1->Teams()->removeByID($team1->ID);
$player1->flushCache(); $player1->flushCache();
$compareTeams = new ManyManyList(); $compareTeams = new ManyManyList('DataObjectTest_Team','DataObjectTest_Team_Players', 'DataObjectTest_TeamID', 'DataObjectTest_PlayerID');
$compareTeams->forForeignID($player1->ID);
$compareTeams->byID($team1->ID);
$this->assertEquals( $this->assertEquals(
$player1->Teams()->column('ID'), $player1->Teams()->column('ID'),
$compareTeams->column('ID'), $compareTeams->column('ID'),