tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #6987 from open-sausages/pull/4.0/3239-consisten-fist-last-returns

Browse Source 
Consistent return values for first and last methods
This commit is contained in:
Daniel Hensby 2017-06-06 16:59:04 +01:00 committed by GitHub
commit 856aa79892
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/ORM/ArrayList.php
View File

@ -302,6 +302,10 @@ class ArrayList extends ViewableData implements SS_List, Filterable, Sortable, L
*/
public function first()
{
if (empty($this->items)) {
return null;
}
return reset($this->items);
}
@ -312,6 +316,10 @@ class ArrayList extends ViewableData implements SS_List, Filterable, Sortable, L
*/
public function last()
{
if (empty($this->items)) {
return null;
}
return end($this->items);
}
@ -514,12 +522,12 @@ class ArrayList extends ViewableData implements SS_List, Filterable, Sortable, L
*/
public function canFilterBy($by)
{
$firstRecord = $this->first();
if ($firstRecord === false) {
if (empty($this->items)) {
return false;
}
$firstRecord = $this->first();
return array_key_exists($by, $firstRecord);
}