tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #9272 from open-sausages/pulls/4/doc-yet-another-link-update

Browse Source 
DOC Fix Contribution guide broken links
This commit is contained in:
Robbie Averill 2019-09-29 19:49:59 -07:00 committed by GitHub
commit 84cb596ab8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
docs/en/05_Contributing/01_Code.md
View File

@ -83,7 +83,7 @@ which gets automatically chosen when creating a new pull request. This ensures y
gets into the next minor release of the current major release.
If you are changing existing APIs, introducing new APIs or major new features,
please review our guidance on [supported versions](release-process#supported-versions).
please review our guidance on [supported versions](release_process#supported-versions).
You will need to change the branch for your pull request accordingly.
@ -112,7 +112,7 @@ The current GitHub labels are grouped into five sections:
| change/major | A change for the next major release (eg: 4.0) |
| change/minor | A change for the next minor release (eg: 3.x) |
| change/patch | A change for the next patch release (eg: 3.1.x) |
| impact/critical | Broken functionality without workarounds, affecting major usage flows. Should target all [supported minor releases](release-process#supported-versions) |
| impact/critical | Broken functionality without workarounds, affecting major usage flows. Should target all [supported minor releases](release_process#supported-versions) |
| impact/high | Broken functionality with workarounds available, affecting major usage flows |
| impact/medium | Unexpected behaviour, or broken functionality on less common usage flows |
| impact/low | A nuisance but doesn't break any functionality (typos, etc) |
@ -124,8 +124,8 @@ The current GitHub labels are grouped into five sections:
| type/ux | User experience impact |
| feedback-required/core-team | Core team members need to give an in-depth consideration |
| feedback-required/author | This issue is awaiting feedback from the original author of the PR |
| rfc/draft | [RFC](request-for-comment) under discussion |
| rfc/accepted | [RFC](request-for-comment) where agreement has been reached |
| rfc/draft | [RFC](request_for_comment) under discussion |
| rfc/accepted | [RFC](request_for_comment) where agreement has been reached |
| affects/* | Issue has been observed on a specific release line |
### Quickfire Do's and Don't's
@ -153,7 +153,7 @@ After you have edited the file, GitHub will offer to create a pull request for y
## Check List
* Adhere to our [coding conventions](/contributing/coding_conventions)
* If your patch is extensive, discuss it first on the [silverstripe-dev google group](https://groups.google.com/group/silverstripe-dev) (ideally before doing any serious coding)
* If your patch is extensive, discuss it first on the [SilverStripe Forums](https://forum.silverstripe.org/c/feature-ideas) (ideally before doing any serious coding)
* When working on existing tickets, provide status updates through ticket comments
* Check your patches against the "master" branch, as well as the latest release branch
* Write [unit tests](../developer_guides/testing/unit_testing)