tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

API Opt-out of in-memory caching factory

Browse Source 
In-memory caches are typically more resource constrained (number of items and storage space).
Give cache consumers an opt-out if they are expecting to create large caches with long lifetimes.
Use case: https://github.com/silverstripe/silverstripe-assets/pull/282
This commit is contained in:
Ingo Schommer 2019-06-06 12:19:16 +12:00 committed by Maxime Rainville
parent e8fa3d8750
commit 8324235eda
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/Core/Cache/DefaultCacheFactory.php
View File

@ -56,8 +56,12 @@ class DefaultCacheFactory implements CacheFactory
$directory = isset($args['directory']) ? $args['directory'] : null; $directory = isset($args['directory']) ? $args['directory'] : null;
$version = isset($args['version']) ? $args['version'] : null; $version = isset($args['version']) ? $args['version'] : null;
// In-memory caches are typically more resource constrained (number of items and storage space).
// Give cache consumers an opt-out if they are expecting to create large caches with long lifetimes.
$useInMemoryCache = isset($args['useInMemoryCache']) ? $args['useInMemoryCache'] : true;
// Check support // Check support
$apcuSupported = $this->isAPCUSupported(); $apcuSupported = ($this->isAPCUSupported() && $useInMemoryCache);
$phpFilesSupported = $this->isPHPFilesSupported(); $phpFilesSupported = $this->isPHPFilesSupported();
// If apcu isn't supported, phpfiles is the next best preference // If apcu isn't supported, phpfiles is the next best preference
@ -72,8 +76,11 @@ class DefaultCacheFactory implements CacheFactory
} }
// Chain this cache with ApcuCache // Chain this cache with ApcuCache
// Note that the cache lifetime will be shorter there by default, to ensure there's enough
// resources for "hot cache" items in APCu as a resource constrained in memory cache.
$apcuNamespace = $namespace . ($namespace ? '_' : '') . md5(BASE_PATH); $apcuNamespace = $namespace . ($namespace ? '_' : '') . md5(BASE_PATH);
$apcu = $this->createCache(ApcuCache::class, [$apcuNamespace, (int) $defaultLifetime / 5, $version]); $apcu = $this->createCache(ApcuCache::class, [$apcuNamespace, (int) $defaultLifetime / 5, $version]);
return $this->createCache(ChainCache::class, [[$apcu, $fs]]); return $this->createCache(ChainCache::class, [[$apcu, $fs]]);
} }