tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

BUGFIX: Ensure $items isn't null in GridFieldDetailForm_ItemRequest->Breadcrumbs() prior to performing operations on it.

Browse Source
This commit is contained in:
Tom Yrjas 2020-06-29 14:12:01 +03:00
parent 64688dbc10
commit 824b5e0b67
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/Forms/GridField/GridFieldDetailForm_ItemRequest.php
View File

@ -786,17 +786,19 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
/** @var ArrayList $items */ /** @var ArrayList $items */
$items = $this->popupController->Breadcrumbs($unlinked); $items = $this->popupController->Breadcrumbs($unlinked);
if ($this->record && $this->record->ID) { if ($items) {
$title = ($this->record->Title) ? $this->record->Title : "#{$this->record->ID}"; if ($this->record && $this->record->ID) {
$items->push(new ArrayData([ $title = ($this->record->Title) ? $this->record->Title : "#{$this->record->ID}";
'Title' => $title, $items->push(new ArrayData([
'Link' => $this->Link() 'Title' => $title,
])); 'Link' => $this->Link()
} else { ]));
$items->push(new ArrayData([ } else {
'Title' => _t('SilverStripe\\Forms\\GridField\\GridField.NewRecord', 'New {type}', ['type' => $this->record->i18n_singular_name()]), $items->push(new ArrayData([
'Link' => false 'Title' => _t('SilverStripe\\Forms\\GridField\\GridField.NewRecord', 'New {type}', ['type' => $this->record->i18n_singular_name()]),
])); 'Link' => false
]));
}
} }
$this->extend('updateBreadcrumbs', $items); $this->extend('updateBreadcrumbs', $items);