From 049e546247ac6957885f862124d23cc50daf5dc9 Mon Sep 17 00:00:00 2001 From: Guy Sartorelli <36352093+GuySartorelli@users.noreply.github.com> Date: Wed, 12 Jun 2024 15:47:12 +1200 Subject: [PATCH] API Deprecate references to installation tool (#11275) --- src/Core/BaseKernel.php | 4 ++++ src/Core/CoreKernel.php | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/Core/BaseKernel.php b/src/Core/BaseKernel.php index 4e6c56a1c..e749ac19e 100644 --- a/src/Core/BaseKernel.php +++ b/src/Core/BaseKernel.php @@ -27,6 +27,7 @@ use SilverStripe\View\SSViewer; use SilverStripe\View\ThemeManifest; use SilverStripe\View\ThemeResourceLoader; use Exception; +use SilverStripe\Dev\Deprecation; /** * Simple Kernel container @@ -308,10 +309,13 @@ abstract class BaseKernel implements Kernel * If missing configuration, redirect to install.php if it exists. * Otherwise show a server error to the user. * + * @deprecated 5.3.0 Will be removed without equivalent functionality + * * @param string $msg Optional message to show to the user on an installed project (install.php missing). */ protected function redirectToInstaller($msg = '') { + Deprecation::notice('5.3.0', 'Will be removed without equivalent functionality'); // Error if installer not available if (!file_exists(Director::publicFolder() . '/install.php')) { throw new HTTPResponse_Exception( diff --git a/src/Core/CoreKernel.php b/src/Core/CoreKernel.php index db9b69f69..7f968c8a3 100644 --- a/src/Core/CoreKernel.php +++ b/src/Core/CoreKernel.php @@ -7,6 +7,7 @@ use SilverStripe\Dev\Install\DatabaseAdapterRegistry; use SilverStripe\ORM\DB; use Exception; use LogicException; +use SilverStripe\Dev\Deprecation; /** * Simple Kernel container @@ -52,7 +53,7 @@ class CoreKernel extends BaseKernel $msg = 'Silverstripe Framework requires a "database" key in DB::getConfig(). ' . 'Did you forget to set SS_DATABASE_NAME or SS_DATABASE_CHOOSE_NAME in your environment?'; $this->detectLegacyEnvironment(); - $this->redirectToInstaller($msg); + Deprecation::withNoReplacement(fn() => $this->redirectToInstaller($msg)); } }