tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

MINOR Added tests for Upload_Validator/UploadTest_Validator for allowed extensions validation (from r100990)

Browse Source 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111561 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
Sam Minnee 2010-10-04 04:29:58 +00:00
parent cb435df6af
commit 7f147f9fab
1 changed files with 63 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
tests/filesystem/UploadTest.php
View File

@ -36,7 +36,7 @@ class UploadTest extends SapphireTest {
'File upload to standard directory in /assets' 'File upload to standard directory in /assets'
); );
$this->assertTrue( $this->assertTrue(
(strpos($file1->getFullPath(),Director::baseFolder() . '/assets/' . Upload::$uploads_folder) !== false), (strpos($file1->getFullPath(), Director::baseFolder() . '/assets/' . Upload::$uploads_folder) !== false),
'File upload to standard directory in /assets' 'File upload to standard directory in /assets'
); );
$file1->delete(); $file1->delete();
@ -51,7 +51,7 @@ class UploadTest extends SapphireTest {
'File upload to custom directory in /assets' 'File upload to custom directory in /assets'
); );
$this->assertTrue( $this->assertTrue(
(strpos($file2->getFullPath(),Director::baseFolder() . '/assets/' . $customFolder) !== false), (strpos($file2->getFullPath(), Director::baseFolder() . '/assets/' . $customFolder) !== false),
'File upload to custom directory in /assets' 'File upload to custom directory in /assets'
); );
$file2->delete(); $file2->delete();
@ -63,8 +63,67 @@ class UploadTest extends SapphireTest {
// @todo // @todo
} }
function testAllowedExtensions() { function testUploadDoesNotAllowUnknownExtension() {
// @todo // create tmp file
$tmpFileName = 'UploadTest_testUpload.php';
$tmpFilePath = TEMP_FOLDER . '/' . $tmpFileName;
$tmpFileContent = '';
for($i=0; $i<10000; $i++) $tmpFileContent .= '0';
file_put_contents($tmpFilePath, $tmpFileContent);
// emulates the $_FILES array
$tmpFile = array(
'name' => $tmpFileName,
'type' => 'text/plaintext',
'size' => filesize($tmpFilePath),
'tmp_name' => $tmpFilePath,
'extension' => 'txt',
'error' => UPLOAD_ERR_OK,
);
$v = new UploadTest_Validator();
$v->setAllowedExtensions(array('txt'));
// test upload into default folder
$u = new Upload();
$u->setValidator($v);
$result = $u->load($tmpFile);
$this->assertFalse($result, 'Load failed because extension was not accepted');
$this->assertEquals(1, count($u->getErrors()), 'There is a single error of the file extension');
}
function testUploadAcceptsAllowedExtension() {
// create tmp file
$tmpFileName = 'UploadTest_testUpload.txt';
$tmpFilePath = TEMP_FOLDER . '/' . $tmpFileName;
$tmpFileContent = '';
for($i=0; $i<10000; $i++) $tmpFileContent .= '0';
file_put_contents($tmpFilePath, $tmpFileContent);
// emulates the $_FILES array
$tmpFile = array(
'name' => $tmpFileName,
'type' => 'text/plaintext',
'size' => filesize($tmpFilePath),
'tmp_name' => $tmpFilePath,
'extension' => 'txt',
'error' => UPLOAD_ERR_OK,
);
$v = new UploadTest_Validator();
$v->setAllowedExtensions(array('txt'));
// test upload into default folder
$u = new Upload();
$u->setValidator($v);
$u->load($tmpFile);
$file = $u->getFile();
$this->assertTrue(
file_exists($file->getFullPath()),
'File upload to custom directory in /assets'
);
$file->delete();
} }
} }