tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

FIX: Use DELETE FROM instead of TRUNCATE for clearTable

Browse Source 
clearTable is mainly used for clearing data between tests. In this case,
there are very few or zero records, and DELETE FROM is quicker than
TRUNCATE, which works by deleting and recreating the table.

This materially speeds up test execution, at least on MySQL.

Implemented in SS3 at 815da76b056a716c8831d22bbf93528912cbcb28
This commit is contained in:
Sam Minnee 2018-10-02 18:00:38 +13:00
parent 755907d117
commit 79c2b5ad42
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/ORM/Connect/Database.php
View File

@ -403,7 +403,7 @@ abstract class Database
*/ */
public function clearTable($table) public function clearTable($table)
{ {
$this->query("TRUNCATE \"$table\""); $this->query("DELETE FROM \"$table\"");
} }
/** /**