tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

ENH Faster method for creating injected instances (#10265)

Browse Source
This commit is contained in:
Steve Boyd 2022-03-23 10:39:58 +13:00 committed by GitHub
parent 76bd8a116a
commit 78c9aea61f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/Core/Injector/InjectionCreator.php
View File

@ -2,29 +2,18 @@
namespace SilverStripe\Core\Injector; namespace SilverStripe\Core\Injector;
use ReflectionClass;
use ReflectionException;
/** /**
* A class for creating new objects by the injector. * A class for creating new objects by the injector.
*/ */
class InjectionCreator implements Factory class InjectionCreator implements Factory
{ {
public function create($class, array $params = []) public function create($class, array $params = [])
{ {
try { if (!class_exists($class)) {
$reflector = new ReflectionClass($class); throw new InjectorNotFoundException("Class {$class} does not exist");
} catch (ReflectionException $e) {
throw new InjectorNotFoundException($e);
} }
// Ensure there are no string keys as they cannot be unpacked with the `...` operator
if (count($params)) { $values = array_values($params);
// Remove named keys to ensure that PHP7 and PHP8 interpret these the same way return new $class(...$values);
$params = array_values($params);
return $reflector->newInstanceArgs($params);
}
return $reflector->newInstance();
} }
} }