From 534e59faad7d2a4468f3305549d4e2e262d31fe4 Mon Sep 17 00:00:00 2001 From: Maxime Rainville Date: Wed, 28 Aug 2019 15:08:55 +1200 Subject: [PATCH 1/3] DOC Explain how to mgirate SS3.2 variants --- .../14_Files/05_File_Migration.md | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md b/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md index e409a1b0c..891198b78 100644 --- a/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md +++ b/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md @@ -176,7 +176,19 @@ After running the file migration, you can run the short code migration task to u sake dev/tasks/TagsToShortcode ``` -This will rewrite your existing shortcodes to the newer format SilverStripe 4 expects as well as convert `img` and `a` tags to use shortcodes.. +This will rewrite your existing shortcodes to the newer format SilverStripe 4 expects as well as convert `img` and `a` tags to use shortcodes. + +### Migrating from SilverStripe 3.2 (or below) to SilverStripe 4.4 + +The format for image variants was changed in SilverStripe 3.3. In SilverStripe 3.2 and below variants would be included in the file name with a dash: +* `Uploads/_resampled/FitWzQwLDMwXQ-image.jpg` in SilverStripe 3.2 and below +* `Uploads/_resampled/FitWzQwLDMwXQ/image.jpg` in SilverStripe 3.3 and above. + +The file migration task didn't account for this nuance until the SilverStripe 4.4.4 release. If you ran the file migration task using a prior version, your SilverStripe 3.2 thumbnails might not have been migrated ... or their path might have been appended as variants. e.g.: `FitWzQwLDMwXQ-image__Uploads__resampled.jpg` + +Those variants will need to be regenarated. Thumbnails generated through templates or code will automatically be regenerated on the next uncached request to SilverStripe. Thumbnails embedded in HTML fields will be regenerated when the page is republished. Variants that got improperly renamed can be removed manually. + +If you are running SilverStripe 4.4.4 or greater, SilverStripe 3.2 variants will be migrated normally. ## Migrating from SilverStripe 4.3 or below to SilverStripe 4.4 or above From c165561580312114d6a827d71fed1fb72bd8815c Mon Sep 17 00:00:00 2001 From: Maxime Rainville Date: Mon, 9 Sep 2019 09:06:40 +1200 Subject: [PATCH 2/3] Fix typos Co-Authored-By: Robbie Averill --- docs/en/02_Developer_Guides/14_Files/05_File_Migration.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md b/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md index 891198b78..63f9097ab 100644 --- a/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md +++ b/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md @@ -184,9 +184,9 @@ The format for image variants was changed in SilverStripe 3.3. In SilverStripe 3 * `Uploads/_resampled/FitWzQwLDMwXQ-image.jpg` in SilverStripe 3.2 and below * `Uploads/_resampled/FitWzQwLDMwXQ/image.jpg` in SilverStripe 3.3 and above. -The file migration task didn't account for this nuance until the SilverStripe 4.4.4 release. If you ran the file migration task using a prior version, your SilverStripe 3.2 thumbnails might not have been migrated ... or their path might have been appended as variants. e.g.: `FitWzQwLDMwXQ-image__Uploads__resampled.jpg` +The file migration task didn't account for this nuance until the SilverStripe 4.4.4 release. If you ran the file migration task using a prior version, your SilverStripe 3.2 thumbnails might not have been migrated, or their paths might have been appended as variants. e.g.: `FitWzQwLDMwXQ-image__Uploads__resampled.jpg` -Those variants will need to be regenarated. Thumbnails generated through templates or code will automatically be regenerated on the next uncached request to SilverStripe. Thumbnails embedded in HTML fields will be regenerated when the page is republished. Variants that got improperly renamed can be removed manually. +Those variants will need to be regenarated. Thumbnails generated through templates or code will automatically be regenerated on the next uncached request to SilverStripe. Thumbnails embedded in HTML fields will be regenerated when the page is republished. Variants that were improperly renamed must be removed manually. If you are running SilverStripe 4.4.4 or greater, SilverStripe 3.2 variants will be migrated normally. From 23719af2a1411655bfdcf99caed4b37f73f84a46 Mon Sep 17 00:00:00 2001 From: Andre Kiste Date: Mon, 9 Sep 2019 13:36:53 +1200 Subject: [PATCH 3/3] Apply suggestions from code review Typos --- docs/en/02_Developer_Guides/14_Files/05_File_Migration.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md b/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md index 63f9097ab..799883302 100644 --- a/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md +++ b/docs/en/02_Developer_Guides/14_Files/05_File_Migration.md @@ -182,11 +182,11 @@ This will rewrite your existing shortcodes to the newer format SilverStripe 4 ex The format for image variants was changed in SilverStripe 3.3. In SilverStripe 3.2 and below variants would be included in the file name with a dash: * `Uploads/_resampled/FitWzQwLDMwXQ-image.jpg` in SilverStripe 3.2 and below -* `Uploads/_resampled/FitWzQwLDMwXQ/image.jpg` in SilverStripe 3.3 and above. +* `Uploads/_resampled/FitWzQwLDMwXQ/image.jpg` in SilverStripe 3.3 and above The file migration task didn't account for this nuance until the SilverStripe 4.4.4 release. If you ran the file migration task using a prior version, your SilverStripe 3.2 thumbnails might not have been migrated, or their paths might have been appended as variants. e.g.: `FitWzQwLDMwXQ-image__Uploads__resampled.jpg` -Those variants will need to be regenarated. Thumbnails generated through templates or code will automatically be regenerated on the next uncached request to SilverStripe. Thumbnails embedded in HTML fields will be regenerated when the page is republished. Variants that were improperly renamed must be removed manually. +Those variants will need to be regenerated. Thumbnails generated through templates or code will automatically be regenerated on the next uncached request to SilverStripe. Thumbnails embedded in HTML fields will be regenerated when the page is republished. Variants that were improperly renamed must be removed manually. If you are running SilverStripe 4.4.4 or greater, SilverStripe 3.2 variants will be migrated normally.