From 725497a485bd0ac345a580ea9eeeda812143ecfd Mon Sep 17 00:00:00 2001 From: Michal Kleiner Date: Mon, 20 Feb 2023 22:40:16 +1300 Subject: [PATCH] MNT Use null safe operator and default to 1 page --- .../GridFieldDetailForm_ItemRequest.php | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php b/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php index 6b9531952..1191cc99d 100644 --- a/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php +++ b/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php @@ -665,18 +665,11 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler */ private function getNumPages(GridField $gridField): int { - /** @var GridFieldPaginator $component */ - $component = $gridField - ->getConfig() - ->getComponentByType(GridFieldPaginator::class); - if (is_null($component)) { - return 1; - } - $params = $component->getTemplateParameters($gridField); - if (is_null($params)) { - return 1; - } - return $params->toMap()['NumPages']; + return $gridField + ->getConfig() + ->getComponentByType(GridFieldPaginator::class) + ?->getTemplateParameters($gridField) + ?->toMap()['NumPages'] ?? 1; } /**