diff --git a/admin/code/LeftAndMain.php b/admin/code/LeftAndMain.php index 8885d1311..faf6f1c6c 100644 --- a/admin/code/LeftAndMain.php +++ b/admin/code/LeftAndMain.php @@ -1345,7 +1345,7 @@ class LeftAndMain extends Controller implements PermissionProvider } $link = Controller::join_links($recordController->Link("show"), $record->ID); - $html = LeftAndMain_TreeNode::create($record, $link, $this->isCurrentPage($record))->forTemplate() ; + $html = LeftAndMain_TreeNode::create($record, $link, $this->isCurrentPage($record))->forTemplate(). ''; $data[$id] = array( 'html' => $html, diff --git a/admin/templates/SilverStripe/Admin/Includes/LeftAndMain_TreeNode.ss b/admin/templates/SilverStripe/Admin/Includes/LeftAndMain_TreeNode.ss index 7e4c8ebf8..c3617f1dd 100644 --- a/admin/templates/SilverStripe/Admin/Includes/LeftAndMain_TreeNode.ss +++ b/admin/templates/SilverStripe/Admin/Includes/LeftAndMain_TreeNode.ss @@ -3,4 +3,3 @@   $TreeTitle - diff --git a/docs/en/02_Developer_Guides/01_Templates/01_Syntax.md b/docs/en/02_Developer_Guides/01_Templates/01_Syntax.md index 8a7f83bee..6237f44e2 100644 --- a/docs/en/02_Developer_Guides/01_Templates/01_Syntax.md +++ b/docs/en/02_Developer_Guides/01_Templates/01_Syntax.md @@ -490,7 +490,7 @@ The `<% with %>` tag lets you change into a new scope. Consider the following ex This is functionalty the same as the following: :::ss - Hello, $CurrentMember.FirstName, welcome back. Yout current balance is $CurrentMember.Balance + Hello, $CurrentMember.FirstName, welcome back. Your current balance is $CurrentMember.Balance Notice that the first example is much tidier, as it removes the repeated use of the `$CurrentMember` accessor. diff --git a/docs/en/04_Changelogs/rc/3.4.5-rc1.md b/docs/en/04_Changelogs/rc/3.4.5-rc1.md new file mode 100644 index 000000000..f7ba17851 --- /dev/null +++ b/docs/en/04_Changelogs/rc/3.4.5-rc1.md @@ -0,0 +1,10 @@ +# 3.4.5-rc1 + + + +## Change Log + +### Bugfixes + + * 2017-01-30 [10d9f90](https://github.com/silverstripe/silverstripe-cms/commit/10d9f9080b6cc6c909abdae796e8ce944036ccc2) to allow ASSETS_DIR to be a subdirectory (Brendan Halley) + * 2017-02-08 [0fe4ec4](https://github.com/silverstripe/silverstripe-framework/commit/0fe4ec4537899fa90870647233772551204ff2a5) Fix issue with nested tree view (Daniel Hensby) \ No newline at end of file diff --git a/docs/en/04_Changelogs/rc/3.5.3-rc1.md b/docs/en/04_Changelogs/rc/3.5.3-rc1.md new file mode 100644 index 000000000..13268fc55 --- /dev/null +++ b/docs/en/04_Changelogs/rc/3.5.3-rc1.md @@ -0,0 +1,10 @@ +# 3.5.3-rc1 + + + +## Change Log + +### Bugfixes + + * 2017-01-30 [10d9f90](https://github.com/silverstripe/silverstripe-cms/commit/10d9f9080b6cc6c909abdae796e8ce944036ccc2) to allow ASSETS_DIR to be a subdirectory (Brendan Halley) + * 2017-02-08 [0fe4ec4](https://github.com/silverstripe/silverstripe-framework/commit/0fe4ec4537899fa90870647233772551204ff2a5) Fix issue with nested tree view (Daniel Hensby) diff --git a/lang/cs.yml b/lang/cs.yml index a29395ac5..3bbf6634a 100644 --- a/lang/cs.yml +++ b/lang/cs.yml @@ -467,6 +467,7 @@ cs: PASSWORD: Heslo PASSWORDEXPIRED: 'Vaše heslo expirovalo. Prosím, zvolte nové heslo.' PLURALNAME: Členové + REMEMBERME: "Zapamatovat si mě pro příště?" SINGULARNAME: Člen SUBJECTPASSWORDCHANGED: 'Vaše heslo bylo změněno' SUBJECTPASSWORDRESET: 'Nulovací odkaz pro Vaše heslo' diff --git a/src/ORM/Hierarchy/Hierarchy.php b/src/ORM/Hierarchy/Hierarchy.php index 446decd3c..44539193e 100644 --- a/src/ORM/Hierarchy/Hierarchy.php +++ b/src/ORM/Hierarchy/Hierarchy.php @@ -149,7 +149,7 @@ class Hierarchy extends DataExtension */ public function getChildrenAsUL( $attributes = "", - $titleEval = '"
  • " . $child->Title . "
  • "', + $titleEval = '"
  • " . $child->Title', $extraArg = null, $limitToMarked = false, $childrenMethod = "AllChildrenIncludingDeleted", @@ -202,10 +202,6 @@ class Hierarchy extends DataExtension } else { $output .= eval("return $titleEval;"); } - $output = trim($output); - if (substr($output, -5) == '
  • ') { - $output = trim(substr($output, 0, -5)); - } $output .= "\n"; $numChildren = $child->$numChildrenMethod(); diff --git a/tests/php/ORM/SQLSelectTest.php b/tests/php/ORM/SQLSelectTest.php index 5ed99590e..223d4dff1 100755 --- a/tests/php/ORM/SQLSelectTest.php +++ b/tests/php/ORM/SQLSelectTest.php @@ -40,13 +40,17 @@ class SQLSelectTest extends SapphireTest //basic counting $qry = SQLSelectTest\TestObject::get()->dataQuery()->getFinalisedQuery(); - $qry->setGroupBy('"Common"'); $ids = $this->allFixtureIDs(SQLSelectTest\TestObject::class); $count = $qry->count('"SQLSelectTest_DO"."ID"'); $this->assertEquals(count($ids), $count); $this->assertInternalType("int", $count); //test with `having` if (DB::get_conn() instanceof MySQLDatabase) { + $qry->setSelect(array( + 'Date' => 'MAX("Date")', + 'Common' => '"Common"', + )); + $qry->setGroupBy('"Common"'); $qry->setHaving('"Date" > 2012-02-01'); $count = $qry->count('"SQLSelectTest_DO"."ID"'); $this->assertEquals(1, $count);