tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

API FormField->setDescription() visible in default template

Browse Source 
Renders into <span class="description"> instead of "title" attribute
This commit is contained in:
Ingo Schommer 2012-12-13 16:22:58 +01:00
parent 255b4c44d3
commit 6f9d01f621
6 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/en/changelogs/3.1.0.md
View File

@ -60,10 +60,10 @@ you'll need to adjust your code.
including `Email_BounceHandler` and `Email_BounceRecord` classes, including `Email_BounceHandler` and `Email_BounceRecord` classes,
as well as the `Member->Bounced` property. as well as the `Member->Bounced` property.
* Deprecated global email methods `htmlEmail()` and `plaintextEmail`, as well as various email helper methods like `encodeMultipart()`. Use the `Email` API, or the `Mailer` class where applicable. * Deprecated global email methods `htmlEmail()` and `plaintextEmail`, as well as various email helper methods like `encodeMultipart()`. Use the `Email` API, or the `Mailer` class where applicable.
* Removed non-functional `$inlineImages` option for sending emails * Removed non-functional `$inlineImages` option for sending emails
* Removed support for keyed arrays in `SelectionGroup`, use new `SelectionGroup_Item` object * Removed support for keyed arrays in `SelectionGroup`, use new `SelectionGroup_Item` object
to populate the list instead (see [API docs](api:SelectionGroup)). to populate the list instead (see [API docs](api:SelectionGroup)).
* Removed `Form->Name()`: Use getName() * `FormField->setDescription()` now renders in a `<span class="description">` by default, rather than a `title` attribute * Removed `Form->Name()`: Use getName()
* Removed `FormField->setContainerFieldSet()`: Use setContainerFieldList() * Removed `FormField->setContainerFieldSet()`: Use setContainerFieldList()
* Removed `FormField->rootFieldSet()`: Use rootFieldList() * Removed `FormField->rootFieldSet()`: Use rootFieldList()
* Removed `Group::map()`: Use DataList::("Group")->map() * Removed `Group::map()`: Use DataList::("Group")->map()

1
forms/FormField.php
View File

@ -356,7 +356,6 @@ class FormField extends RequestHandler {
'class' => $this->extraClass(), 'class' => $this->extraClass(),
'id' => $this->ID(), 'id' => $this->ID(),
'disabled' => $this->isDisabled(), 'disabled' => $this->isDisabled(),
'title' => $this->getDescription(),
); );
return array_merge($attrs, $this->attributes); return array_merge($attrs, $this->attributes);

2
templates/forms/CheckboxSetField.ss
View File

@ -1,4 +1,4 @@
<ul id="$ID" class="$extraClass"<% if Description %> title="$Description"<% end_if %>> <ul id="$ID" class="$extraClass">
<% if Options.Count %> <% if Options.Count %>
<% loop Options %> <% loop Options %>
<li class="$Class"> <li class="$Class">

4
templates/forms/FormField.ss
View File

@ -1,7 +1,5 @@
<% if isReadonly %> <% if isReadonly %>
<span id="$ID" <span id="$ID"<% if extraClass %> class="$extraClass"<% end_if %>>
<% if extraClass %>class="$extraClass"<% end_if %>
<% if $Description %>title="$Description"<% end_if %>>
$Value $Value
</span> </span>
<% else %> <% else %>

1
templates/forms/FormField_holder.ss
View File

@ -5,4 +5,5 @@
</div> </div>
<% if RightTitle %><label class="right" for="$ID">$RightTitle</label><% end_if %> <% if RightTitle %><label class="right" for="$ID">$RightTitle</label><% end_if %>
<% if Message %><span class="message $MessageType">$Message</span><% end_if %> <% if Message %><span class="message $MessageType">$Message</span><% end_if %>
<% if Description %><span class="description">$Description</span><% end_if %>
</div> </div>

2
templates/forms/OptionsetField.ss
View File

@ -1,4 +1,4 @@
<ul id="$ID" class="$extraClass"<% if Description %> title="$Description"<% end_if %>> <ul id="$ID" class="$extraClass">
<% loop Options %> <% loop Options %>
<li class="$Class"> <li class="$Class">
<input id="$ID" class="radio" name="$Name" type="radio" value="$Value"<% if isChecked %> checked<% end_if %><% if isDisabled %> disabled<% end_if %> /> <input id="$ID" class="radio" name="$Name" type="radio" value="$Value"<% if isChecked %> checked<% end_if %><% if isDisabled %> disabled<% end_if %> />