mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-10-04 07:08:34 +02:00
BUG GridState_Data doesn't hold falsey values
After patch #2522 was taken GridField_Data was no longer able to hold falsey values. See failing tests.
This commit is contained in:
parent
d6deffe8a6
commit
6df276c843
@ -124,6 +124,27 @@ class GridFieldTest extends SapphireTest {
|
|||||||
$this->assertEquals(10, $obj->State->NoValue);
|
$this->assertEquals(10, $obj->State->NoValue);
|
||||||
$this->assertEquals(10, $obj->State->NoValue(20));
|
$this->assertEquals(10, $obj->State->NoValue(20));
|
||||||
|
|
||||||
|
//Show that values returned by the assignment function don't
|
||||||
|
// actually return the value stored
|
||||||
|
$this->assertEquals(0, $obj->State->Falsey0(0)); // expect 0 back
|
||||||
|
$this->assertEquals(0, $obj->State->Falsey0(10)); // expect 0 back
|
||||||
|
$this->assertEquals(0, $obj->State->Falsey0); //expect 0 back
|
||||||
|
$obj->State->Falsey0 = 0; //manually assign 0
|
||||||
|
$this->assertEquals(0, $obj->State->Falsey0); //expect 0 back
|
||||||
|
|
||||||
|
//repeat for other falsey values
|
||||||
|
$this->assertEquals(array(), $obj->State->Falsey1(array()));
|
||||||
|
$this->assertEquals(array(), $obj->State->Falsey1(array('test')));
|
||||||
|
$this->assertEquals(array(), $obj->State->Falsey1);
|
||||||
|
$obj->State->Falsey1 = array(); //manually assign 0
|
||||||
|
$this->assertEquals(array(), $obj->State->Falsey1); //expect 0 back
|
||||||
|
|
||||||
|
$this->assertFalse($obj->State->Falsey2(false));
|
||||||
|
$this->assertFalse($obj->State->Falsey2(true));
|
||||||
|
$this->assertFalse($obj->State->Falsey2);
|
||||||
|
$obj->State->Falsey2 = false;
|
||||||
|
$this->assertFalse($obj->State->Falsey2);
|
||||||
|
|
||||||
// Check nested values
|
// Check nested values
|
||||||
$this->assertInstanceOf('GridState_Data', $obj->State->Nested);
|
$this->assertInstanceOf('GridState_Data', $obj->State->Nested);
|
||||||
$this->assertInstanceOf('GridState_Data', $obj->State->Nested->DeeperNested());
|
$this->assertInstanceOf('GridState_Data', $obj->State->Nested->DeeperNested());
|
||||||
|
Loading…
Reference in New Issue
Block a user