tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

BUG GridState_Data doesn't hold falsey values

Browse Source 
After patch #2522 was taken GridField_Data was no longer able to hold
falsey values. See failing tests.
This commit is contained in:
Daniel Hensby 2014-01-31 16:35:34 +00:00 committed by Damian Mooyman
parent d6deffe8a6
commit 6df276c843
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/forms/GridFieldTest.php
View File

@ -123,6 +123,27 @@ class GridFieldTest extends SapphireTest {
$obj->State->NoValue = 10;
$this->assertEquals(10, $obj->State->NoValue);
$this->assertEquals(10, $obj->State->NoValue(20));
//Show that values returned by the assignment function don't
// actually return the value stored
$this->assertEquals(0, $obj->State->Falsey0(0)); // expect 0 back
$this->assertEquals(0, $obj->State->Falsey0(10)); // expect 0 back
$this->assertEquals(0, $obj->State->Falsey0); //expect 0 back
$obj->State->Falsey0 = 0; //manually assign 0
$this->assertEquals(0, $obj->State->Falsey0); //expect 0 back
//repeat for other falsey values
$this->assertEquals(array(), $obj->State->Falsey1(array()));
$this->assertEquals(array(), $obj->State->Falsey1(array('test')));
$this->assertEquals(array(), $obj->State->Falsey1);
$obj->State->Falsey1 = array(); //manually assign 0
$this->assertEquals(array(), $obj->State->Falsey1); //expect 0 back
$this->assertFalse($obj->State->Falsey2(false));
$this->assertFalse($obj->State->Falsey2(true));
$this->assertFalse($obj->State->Falsey2);
$obj->State->Falsey2 = false;
$this->assertFalse($obj->State->Falsey2);
// Check nested values
$this->assertInstanceOf('GridState_Data', $obj->State->Nested);