tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

FIX Don't replace config manifest for nested kernels (#11082)

Browse Source
This commit is contained in:
Guy Sartorelli 2023-11-30 11:39:14 +13:00 committed by GitHub
parent 1d69236229
commit 6d903848ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Core/BaseKernel.php
View File

@ -115,11 +115,13 @@ abstract class BaseKernel implements Kernel
$this->setModuleLoader($moduleLoader); $this->setModuleLoader($moduleLoader);
// Config loader // Config loader
// @todo refactor CoreConfigFactory $configLoader = ConfigLoader::inst();
// If nesting kernels, don't create a new config manifest as that will reset config deltas
if (!$configLoader->hasManifest()) {
$configFactory = new CoreConfigFactory($manifestCacheFactory); $configFactory = new CoreConfigFactory($manifestCacheFactory);
$configManifest = $configFactory->createRoot(); $configManifest = $configFactory->createRoot();
$configLoader = ConfigLoader::inst();
$configLoader->pushManifest($configManifest); $configLoader->pushManifest($configManifest);
}
$this->setConfigLoader($configLoader); $this->setConfigLoader($configLoader);
// Load template manifest // Load template manifest