tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-09-19 16:06:32 +02:00
Code Issues Projects Releases Wiki Activity

NEW: Iterate ArrayList via a generator

Browse Source 
Using a generator here means that we don’t need to prepare a duplicate
array in-memory before iterating.
This commit is contained in:
Sam Minnee 2017-01-17 12:52:14 +13:00 committed by Guy Sartorelli
parent 2ead3746d6
commit 6c136c9cf2
No known key found for this signature in database
GPG Key ID: F313E3B9504D496A
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/ORM/ArrayList.php
View File

@ -109,13 +109,13 @@ class ArrayList extends ViewableData implements SS_List, Filterable, Sortable, L
#[\ReturnTypeWillChange] #[\ReturnTypeWillChange]
public function getIterator() public function getIterator()
{ {
$items = array_map( foreach ($this->items as $i => $item) {
function ($item) { if (is_array($item)) {
return is_array($item) ? new ArrayData($item) : $item; yield new ArrayData($item);
}, } else {
$this->items ?? [] yield $item;
); }
return new ArrayIterator($items); }
} }
/** /**