tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-06-26 06:29:24 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: Removed notice-level errors from form field construction.

Browse Source
This commit is contained in:
Sam Minnee 2012-01-10 16:58:27 +13:00
parent 7c6050b407
commit 6a08a82c9c
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
forms/DateField.php
View File

@ -107,7 +107,7 @@ class DateField extends TextField {
} }
} }
parent::__construct($name, $title, $value, $form, $rightTitle); parent::__construct($name, $title, $value);
} }
function FieldHolder() { function FieldHolder() {

1
forms/FormField.php
View File

@ -106,7 +106,6 @@ class FormField extends RequestHandler {
$this->title = ($title === null) ? $name : $title; $this->title = ($title === null) ? $name : $title;
if($value !== NULL) $this->setValue($value); if($value !== NULL) $this->setValue($value);
if($form) $this->setForm($form);
parent::__construct(); parent::__construct();
} }

4
tests/forms/TextareaFieldTest.php
View File

@ -7,7 +7,7 @@ class TextareaFieldTest extends SapphireTest {
*/ */
function testTextEncoding() { function testTextEncoding() {
$inputText = "This is my <text>These are some unicodes: äöü&<>"; $inputText = "This is my <text>These are some unicodes: äöü&<>";
$field = new TextareaField("Test", "Test", 5, 20); $field = new TextareaField("Test", "Test");
$field->setValue($inputText); $field->setValue($inputText);
$this->assertContains('This is my &lt;text&gt;These are some unicodes: &auml;&ouml;&uuml;&amp;&lt;&gt;', $field->Field()); $this->assertContains('This is my &lt;text&gt;These are some unicodes: &auml;&ouml;&uuml;&amp;&lt;&gt;', $field->Field());
} }
@ -17,7 +17,7 @@ class TextareaFieldTest extends SapphireTest {
*/ */
function testReadonlyTextEncoding() { function testReadonlyTextEncoding() {
$inputText = "This is my <text>These are some unicodes: äöü&<>"; $inputText = "This is my <text>These are some unicodes: äöü&<>";
$field = new TextareaField("Test", "Test", 5, 20); $field = new TextareaField("Test", "Test");
$field = $field->performReadonlyTransformation(); $field = $field->performReadonlyTransformation();
$field->setValue($inputText); $field->setValue($inputText);
$this->assertContains('This is my &lt;text&gt;These are some unicodes: &auml;&ouml;&uuml;&amp;&lt;&gt;', $field->Field()); $this->assertContains('This is my &lt;text&gt;These are some unicodes: &auml;&ouml;&uuml;&amp;&lt;&gt;', $field->Field());