From 69229baeaf7fedd5ba343608e29cf7fbad4da45d Mon Sep 17 00:00:00 2001 From: Sean Harvey Date: Mon, 21 Dec 2009 01:10:42 +0000 Subject: [PATCH] BUGFIX #4140 When clicking a tree node that was just dragged, "Stack overflow" error would be given in IE. Firebug would report "Too much recursion" git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@95973 467b73ca-7a2a-4603-9d3b-597d59a354a9 --- javascript/tree/tree.js | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/javascript/tree/tree.js b/javascript/tree/tree.js index 47cff9a31..2e13fd68a 100644 --- a/javascript/tree/tree.js +++ b/javascript/tree/tree.js @@ -734,23 +734,10 @@ DraggableTreeNode.prototype = { this.aTag._onclick_before_draggable = this.aTag.onclick; this.aTag.baseClick = this.aTag.onclick; - this.aTag.onclick = this.aTagOnClick.bindAsEventListener(this.aTag); - if(this.options.onParentChanged) this.onParentChanged = this.options.onParentChanged; if(this.options.onOrderChanged) this.onOrderChanged = this.options.onOrderChanged; }, - aTagOnClick: function(event) { - // This will be bound to the tag, not the
  • . - if(this.treeNode.wasDragged) { - Event.stop(event); - return false; - } else { - this.treeNode.anchorWasClicked = true; - this.treeNode.wasDragged = false; - return this.baseClick(event); - } - }, /** * Remove all the draggy stuff */