tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

BUG Fix incorrect display logic on password field

Browse Source
This commit is contained in:
Damian Mooyman 2018-02-13 10:29:13 +13:00
parent ec6784246f
commit 6570599aa9
No known key found for this signature in database
GPG Key ID: 78B823A10DE27D1A
1 changed files with 30 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

53
src/Forms/ConfirmedPasswordField.php
View File

@ -6,6 +6,7 @@ use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\DataObjectInterface; use SilverStripe\ORM\DataObjectInterface;
use SilverStripe\Security\Authenticator; use SilverStripe\Security\Authenticator;
use SilverStripe\Security\Security; use SilverStripe\Security\Security;
use SilverStripe\View\HTML;
/** /**
* Two masked input fields, checks for matching passwords. * Two masked input fields, checks for matching passwords.
@ -186,24 +187,8 @@ class ConfirmedPasswordField extends FormField
*/ */
public function Field($properties = array()) public function Field($properties = array())
{ {
$content = ''; // Build inner content
$fieldContent = '';
if ($this->showOnClick) {
if ($this->showOnClickTitle) {
$title = $this->showOnClickTitle;
} else {
$title = _t(
'SilverStripe\\Forms\\ConfirmedPasswordField.SHOWONCLICKTITLE',
'Change Password',
'Label of the link which triggers display of the "change password" formfields'
);
}
$content .= "<div class=\"showOnClick\">\n";
$content .= "<a href=\"#\">{$title}</a>\n";
$content .= "<div class=\"showOnClickContainer\">";
}
foreach ($this->children as $field) { foreach ($this->children as $field) {
/** @var FormField $field */ /** @var FormField $field */
$field->setDisabled($this->isDisabled()); $field->setDisabled($this->isDisabled());
@ -215,15 +200,37 @@ class ConfirmedPasswordField extends FormField
} }
} }
$content .= $field->FieldHolder(); $fieldContent .= $field->FieldHolder();
} }
if ($this->showOnClick) { if (!$this->showOnClick) {
$content .= "</div>\n"; return $fieldContent;
$content .= "</div>\n";
} }
return $content; if ($this->showOnClickTitle) {
$title = $this->showOnClickTitle;
} else {
$title = _t(
__CLASS__ . '.SHOWONCLICKTITLE',
'Change Password',
'Label of the link which triggers display of the "change password" formfields'
);
}
// Check if the field should be visible up front
$visible = $this->hiddenField->Value();
$classes = $visible
? 'showOnClickContainer'
: 'showOnClickContainer d-none';
// Build display holder
$container = HTML::createTag('div', ['class' => $classes], $fieldContent);
$actionLink = HTML::createTag('a', ['href' => '#'], $title);
return HTML::createTag(
'div',
['class' => 'showOnClick'],
$actionLink . "\n" . $container
);
} }
/** /**