From d8e354d144383fb6459adf92731853d2e54268d6 Mon Sep 17 00:00:00 2001 From: Damian Mooyman Date: Mon, 25 Jan 2016 11:09:37 +1300 Subject: [PATCH] FIX PHPDocs on DataList::getIDList() and UnsavedRelationList::getIDList() --- model/DataList.php | 2 ++ model/UnsavedRelationList.php | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/model/DataList.php b/model/DataList.php index ed0c5f0c7..f7cfc92b6 100644 --- a/model/DataList.php +++ b/model/DataList.php @@ -916,7 +916,9 @@ class DataList extends ViewableData implements SS_List, SS_Filterable, SS_Sortab /** * Returns an array with both the keys and values set to the IDs of the records in this list. + * Does not respect sort order. Use ->column("ID") to get an ID list with the current sort. * + * @return array */ public function getIDList() { $ids = $this->column("ID"); diff --git a/model/UnsavedRelationList.php b/model/UnsavedRelationList.php index 05db48c92..cce190872 100644 --- a/model/UnsavedRelationList.php +++ b/model/UnsavedRelationList.php @@ -206,8 +206,10 @@ class UnsavedRelationList extends ArrayList { /** * Returns an array with both the keys and values set to the IDs of the records in this list. + * Does not respect sort order. Use ->column("ID") to get an ID list with the current sort. + * Does not return the IDs for unsaved DataObjects. * - * Does not return the IDs for unsaved DataObjects + * @return array */ public function getIDList() { // Get a list of IDs of our current items - if it's not a number then object then assume it's a DO.