tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-09-19 16:06:32 +02:00
Code Issues Projects Releases Wiki Activity

SECURITY Sanitize messages passed to generated JS calls in FormResponse::status_message(), e.g. to avoid XSS on 'Successfully published <page title>' messages

Browse Source
This commit is contained in:
Ingo Schommer 2012-01-31 15:01:59 +01:00
parent 84f47f5c86
commit 5fe7091dff
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/control/FormResponse.php
View File

@ -148,8 +148,8 @@ class FormResponse {
* @param $status string * @param $status string
*/ */
static function status_message($message = "", $status = null) { static function status_message($message = "", $status = null) {
$JS_message = Convert::raw2js($message); $JS_message = Convert::raw2js(Convert::raw2xml($message));
$JS_status = Convert::raw2js($status); $JS_status = Convert::raw2js(Convert::raw2xml($status));
if(isset($JS_status)) { if(isset($JS_status)) {
self::$status_messages[$JS_status] = "statusMessage('{$JS_message}', '{$JS_status}');"; self::$status_messages[$JS_status] = "statusMessage('{$JS_message}', '{$JS_status}');";
} else { } else {