tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #296 from halkyon/old_js_validation_remnants

Browse Source 
MINOR Removing old client side validation remains - NumericField.js
This commit is contained in:
Ingo Schommer 2012-04-11 06:15:25 -07:00
commit 5ea080a585
2 changed files with 1 additions and 68 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
forms/NumericField.php
View File

@ -6,18 +6,11 @@
* @subpackage fields-formattedinput * @subpackage fields-formattedinput
*/ */
class NumericField extends TextField{ class NumericField extends TextField{
function Field() {
$html = parent::Field();
Requirements::javascript(SAPPHIRE_DIR . 'javascript/NumericField.js');
return $html;
}
function Type() { function Type() {
return 'numeric text'; return 'numeric text';
} }
/** PHP Validation **/ /** PHP Validation **/
function validate($validator){ function validate($validator){
if($this->value && !is_numeric(trim($this->value))){ if($this->value && !is_numeric(trim($this->value))){

60
javascript/NumericField.js
View File

@ -1,60 +0,0 @@
NumericField = Class.create();
NumericField.applyTo('input.numeric');
NumericField.prototype = {
initialize: function() {
this.oldValue = this.value;
},
setRange: function( minValue, maxValue ) {
this.minValue = minValue;
this.maxValue = maxValue;
},
onkeyup: function() {
var testValue = this.value;
if( testValue == this.oldValue )
return;
var length = this.maxLength;
this.value = '';
var testedOk = true;
var regex = new RegExp( '^\\d{0,' + length + '}$' );
// check that the value is numeric
if( !testValue.match( regex ) )
testedOk = false;
if( testedOk && testValue.length > 0 ) {
// check that the number is not outside the range
if( testedOk && typeof this.minValue != 'undefined' && parseInt(testValue) < this.minValue )
testedOk = false;
if( testedOk && typeof this.maxValue != 'undefined' && parseInt(testValue) > this.maxValue )
testedOk = false;
// use any external tests
if( testedOk && typeof this.externalValidate != 'undefined' && !this.externalValidate( testValue ) )
testedOk = false;
}
if( testedOk ) {
this.oldValue = this.value = testValue;
// DEBUG This produces weird javascript-errors, and is not very useable at all
// DONT MERGE
/*
if( this.value.length == this.maxLength && this.nextField )
this.nextField.focus();
*/
if( this.callOnValidate )
this.callOnValidate();
} else
this.value = this.oldValue;
}
}