From 729e8ea3e19d74092ba77244a5fc074b2007a73d Mon Sep 17 00:00:00 2001 From: Jeremy Roundill Date: Tue, 11 Nov 2014 19:44:06 +1300 Subject: [PATCH 1/2] Parsing fix for searching on DateFields --- admin/code/ModelAdmin.php | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/admin/code/ModelAdmin.php b/admin/code/ModelAdmin.php index aa4ae67d4..2f9f0cd72 100644 --- a/admin/code/ModelAdmin.php +++ b/admin/code/ModelAdmin.php @@ -227,6 +227,14 @@ abstract class ModelAdmin extends LeftAndMain { public function getList() { $context = $this->getSearchContext(); $params = $this->request->requestVar('q'); + + // Parse all DateFields to handle user input non ISO 8601 dates + foreach(singleton($this->modelClass)->getDefaultSearchContext()->getFields() as $field) { + if($field->Type() == "date text") { + $params[$field->getName()] = date('Y-m-d', strtotime($params[$field->getName()])); + } + } + $list = $context->getResults($params); $this->extend('updateList', $list); From ae4108bf00e9503c5748c4129df7e1c3ea8c8b5f Mon Sep 17 00:00:00 2001 From: Anton Smith Date: Thu, 29 Sep 2016 13:25:14 +1300 Subject: [PATCH 2/2] BUG Content-Disposition header breaks in Firefox (#4087) --- control/HTTPRequest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/control/HTTPRequest.php b/control/HTTPRequest.php index 3de2a3668..81b4ab9f2 100644 --- a/control/HTTPRequest.php +++ b/control/HTTPRequest.php @@ -397,7 +397,7 @@ class SS_HTTPRequest implements ArrayAccess { $response = new SS_HTTPResponse($fileData); $response->addHeader("Content-Type", "$mimeType; name=\"" . addslashes($fileName) . "\""); // Note a IE-only fix that inspects this header in HTTP::add_cache_headers(). - $response->addHeader("Content-Disposition", "attachment; filename=" . addslashes($fileName)); + $response->addHeader("Content-Disposition", "attachment; filename=\"" . addslashes($fileName) . "\""); $response->addHeader("Content-Length", strlen($fileData)); return $response;