From 5bd05a2deba610e67836c1f6f292ce02b6aa743a Mon Sep 17 00:00:00 2001 From: Robbie Averill Date: Sat, 20 Oct 2018 14:51:53 +0200 Subject: [PATCH] Reduce setUp visibility and remove check for CLI - tests always run on CLI now --- tests/php/Logging/HTTPOutputHandlerTest.php | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/php/Logging/HTTPOutputHandlerTest.php b/tests/php/Logging/HTTPOutputHandlerTest.php index 352fdf13d..198361bf5 100644 --- a/tests/php/Logging/HTTPOutputHandlerTest.php +++ b/tests/php/Logging/HTTPOutputHandlerTest.php @@ -3,7 +3,6 @@ namespace SilverStripe\Logging\Tests; use Monolog\Handler\HandlerInterface; -use PhpParser\Node\Scalar\MagicConst\Dir; use SilverStripe\Control\Director; use SilverStripe\Core\Injector\Injector; use SilverStripe\Dev\SapphireTest; @@ -13,14 +12,12 @@ use SilverStripe\Logging\HTTPOutputHandler; class HTTPOutputHandlerTest extends SapphireTest { - public function setUp() + protected function setUp() { parent::setUp(); - if (!Director::is_cli()) { - $this->markTestSkipped("This test only runs in CLI mode"); - } + if (!Director::isDev()) { - $this->markTestSkipped("This test only runs in dev mode"); + $this->markTestSkipped('This test only runs in dev mode'); } }