tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-06-29 16:09:23 +02:00
Code Issues Projects Releases Wiki Activity

Moved checkboxset option list generation to separate method

Browse Source 
This allows subclasses and extensions time to modify the list of options and their configuration without having to override the entire Field method.

A more flexible way to implement silverstripe#3311
This commit is contained in:
Will Rossiter 2014-07-22 23:48:45 +12:00
parent 59e7f777a2
commit 5a14b7227c
1 changed files with 48 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
forms/CheckboxSetField.php
View File

@ -50,6 +50,21 @@ class CheckboxSetField extends OptionsetField {
public function Field($properties = array()) {
Requirements::css(FRAMEWORK_DIR . '/css/CheckboxSetField.css');
$properties = array_merge($properties, array(
'Options' => $this->getOptions()
));
return $this->customise($properties)->renderWith(
$this->getTemplates()
);
}
/**
* @return ArrayList
*/
public function getOptions() {
$odd = 0;
$source = $this->source;
$values = $this->value;
$items = array();
@ -104,12 +119,12 @@ class CheckboxSetField extends OptionsetField {
unset($source['']);
}
$odd = 0;
$options = array();
if ($source == null) $source = array();
if ($source == null) {
$source = array();
}
if($source) {
foreach($source as $value => $item) {
if($item instanceof DataObject) {
$value = $item->ID;
@ -133,11 +148,12 @@ class CheckboxSetField extends OptionsetField {
'isDisabled' => $this->disabled || in_array($value, $this->disabledItems)
));
}
}
$properties = array_merge($properties, array('Options' => new ArrayList($options)));
$options = new ArrayList($options);
return $this->customise($properties)->renderWith($this->getTemplates());
$this->extend('updateGetOptions', $options);
return $options;
}
/**