tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

FIX: Don't mistake \ for _ in dev/build

Browse Source 
The query SHOW TABLES LIKE 'some_thing' will match the table some\thing.

This causes issues when the namespace separator has changed.

The fix is to escape the _s in this LIKE statement, as done here.
This commit is contained in:
Sam Minnee 2017-03-28 18:14:32 +13:00
parent 6f6a53c17c
commit 59a5eb4308
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ORM/Connect/MySQLSchemaManager.php
View File

@ -185,7 +185,8 @@ class MySQLSchemaManager extends DBSchemaManager
public function hasTable($table) public function hasTable($table)
{ {
// MySQLi doesn't like parameterised queries for some queries // MySQLi doesn't like parameterised queries for some queries
$sqlTable = $this->database->quoteString($table); // underscores need to be escaped in a SHOW TABLES LIKE query
$sqlTable = str_replace('_', '\\_', $this->database->quoteString($table));
return (bool) ($this->query("SHOW TABLES LIKE $sqlTable")->value()); return (bool) ($this->query("SHOW TABLES LIKE $sqlTable")->value());
} }