tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

FIX Set tableName on DBField before calling addToQuery (#10946)

Browse Source
This commit is contained in:
Guy Sartorelli 2023-09-14 11:01:36 +12:00 committed by GitHub
parent 95944448a3
commit 58696e3ed5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ORM/DataQuery.php
View File

@ -603,6 +603,7 @@ class DataQuery
$schema = DataObject::getSchema(); $schema = DataObject::getSchema();
$databaseFields = $schema->databaseFields($tableClass, false); $databaseFields = $schema->databaseFields($tableClass, false);
$compositeFields = $schema->compositeFields($tableClass, false); $compositeFields = $schema->compositeFields($tableClass, false);
$tableName = $schema->tableName($tableClass);
unset($databaseFields['ID']); unset($databaseFields['ID']);
foreach ($databaseFields as $k => $v) { foreach ($databaseFields as $k => $v) {
if ((is_null($columns) || in_array($k, $columns ?? [])) && !isset($compositeFields[$k])) { if ((is_null($columns) || in_array($k, $columns ?? [])) && !isset($compositeFields[$k])) {
@ -618,12 +619,12 @@ class DataQuery
$query->selectField($quotedField, $k); $query->selectField($quotedField, $k);
} }
$dbO = Injector::inst()->create($v, $k); $dbO = Injector::inst()->create($v, $k);
$dbO->setTable($tableName);
$dbO->addToQuery($query); $dbO->addToQuery($query);
} }
} }
foreach ($compositeFields as $k => $v) { foreach ($compositeFields as $k => $v) {
if ((is_null($columns) || in_array($k, $columns ?? [])) && $v) { if ((is_null($columns) || in_array($k, $columns ?? [])) && $v) {
$tableName = $schema->tableName($tableClass);
$dbO = Injector::inst()->create($v, $k); $dbO = Injector::inst()->create($v, $k);
$dbO->setTable($tableName); $dbO->setTable($tableName);
$dbO->addToQuery($query); $dbO->addToQuery($query);

5
tests/php/ORM/DataQueryTest.php
View File

@ -387,8 +387,9 @@ class DataQueryTest extends SapphireTest
// Including filter on parent table only doesn't pull in second // Including filter on parent table only doesn't pull in second
$query = new DataQuery(DataQueryTest\DataObjectAddsToQuery::class); $query = new DataQuery(DataQueryTest\DataObjectAddsToQuery::class);
$result = $query->getFinalisedQuery(); $result = $query->getFinalisedQuery();
// The `DBFieldAddsToQuery` test field removes itself from the select query // The `DBFieldAddsToQuery` test field adds a new field to the select query
$this->assertArrayNotHasKey('FieldTwo', $result->getSelect()); $this->assertArrayHasKey('FieldTwo2', $result->getSelect());
$this->assertSame('"DataQueryTest_AddsToQuery"."FieldTwo"', $result->getSelect()['FieldTwo2']);
} }
/** /**

7
tests/php/ORM/DataQueryTest/DBFieldAddsToQuery.php
View File

@ -4,13 +4,14 @@ namespace SilverStripe\ORM\Tests\DataQueryTest;
use SilverStripe\Dev\TestOnly; use SilverStripe\Dev\TestOnly;
use SilverStripe\ORM\FieldType\DBText; use SilverStripe\ORM\FieldType\DBText;
use SilverStripe\ORM\Queries\SQLSelect;
class DBFieldAddsToQuery extends DBText implements TestOnly class DBFieldAddsToQuery extends DBText implements TestOnly
{ {
public function addToQuery(&$query) public function addToQuery(&$query)
{ {
$select = $query->getSelect(); // Add a new item, to validate that tableName and name are set correctly.
unset($select[$this->name]); /** @var SQLSelect $query */
$query->setSelect($select); $query->addSelect([$this->name . '2' => '"' . $this->tableName . '"."' . $this->name . '"']);
} }
} }