tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Added a check for configured fieldname conflict with inherited methods

Browse Source
This commit is contained in:
Jackson Darlow 2020-06-16 17:08:19 +12:00
parent 09aba3594d
commit 55cb8f37ea
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/ORM/DataObject.php
View File

@ -3451,6 +3451,17 @@ class DataObject extends ViewableData implements DataObjectInterface, i18nEntity
);
}
// Sanity check for fields that conflict with parent
foreach (array_keys($fields) as $fieldName) {
if (method_exists(get_parent_class($this), $fieldName)) {
throw new LogicException(sprintf(
'\'%s\' has a $db field named "%s" that coincides with an inherited method of the same name.',
static::class,
$fieldName
));
}
}
if ($fields) {
$hasAutoIncPK = get_parent_class($this) === self::class;
DB::require_table(