tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Fixed react-bootstrap tabs warnings

Browse Source 
We can't use our own "id" values here, since react-bootstrap requires internal consistency
between tab containers and tab panes through its own auto-generated identifiers
This commit is contained in:
Ingo Schommer 2016-09-14 15:07:10 +12:00
parent 368d3ee65e
commit 5415afe8bf
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
admin/client/src/components/Tabs/TabItem.js
View File

@ -17,7 +17,6 @@ class TabItem extends SilverStripeComponent {
onExiting,
onExited,
animation,
id,
unmountOnExit,
} = this.props;
@ -33,9 +32,7 @@ class TabItem extends SilverStripeComponent {
onExiting,
onExited,
animation,
id,
unmountOnExit,
'aria-labelledby': this.props['aria-labelledby'],
};
}

2
admin/client/src/components/Tabs/Tabs.js
View File

@ -14,6 +14,7 @@ class Tabs extends SilverStripeComponent {
onSelect,
className,
extraClass,
id,
} = this.props;
const combinedClassName = `${className} ${extraClass}`;
@ -22,6 +23,7 @@ class Tabs extends SilverStripeComponent {
className: combinedClassName,
defaultActiveKey: this.getDefaultActiveKey(),
onSelect,
id,
};
}