tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #8511 from jmfederico/patch-1

Browse Source 
Update comment about locks in MySQL
This commit is contained in:
Sam Minnée 2018-11-05 22:32:18 +13:00 committed by GitHub
commit 536e2d6835
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/ORM/Connect/MySQLDatabase.php
View File

@ -495,8 +495,9 @@ class MySQLDatabase extends Database
{ {
$id = $this->getLockIdentifier($name); $id = $this->getLockIdentifier($name);
// MySQL auto-releases existing locks on subsequent GET_LOCK() calls, // MySQL 5.7.4 and below auto-releases existing locks on subsequent GET_LOCK() calls.
// in contrast to PostgreSQL and SQL Server who stack the locks. // MySQL 5.7.5 and newer allow multiple locks per sessions even with the same name.
// https://dev.mysql.com/doc/refman/5.7/en/miscellaneous-functions.html#function_get-lock
return (bool) $this->query(sprintf("SELECT GET_LOCK('%s', %d)", $id, $timeout))->value(); return (bool) $this->query(sprintf("SELECT GET_LOCK('%s', %d)", $id, $timeout))->value();
} }