tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Better exception handling for PopoverField

Browse Source
This commit is contained in:
Ingo Schommer 2016-08-28 13:45:16 +12:00
parent bd9997f79a
commit 52686aa4ad
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
forms/PopoverField.php
View File

@ -26,7 +26,8 @@ class PopoverField extends FieldGroup
protected $popoverTitle = null; protected $popoverTitle = null;
/** /**
* Placement of the popup box * Placement of the popup box, relative to the element triggering it.
* Valid values: bottom, top, left, right.
* *
* @var string * @var string
*/ */
@ -68,9 +69,14 @@ class PopoverField extends FieldGroup
{ {
$valid = ['top', 'right', 'bottom', 'left']; $valid = ['top', 'right', 'bottom', 'left'];
if (in_array($placement, $valid)) { if (!in_array($placement, $valid)) {
$this->placement = $placement; throw new InvalidArgumentException(
'Invalid placement value. Valid: top, left, bottom, right'
);
} }
$this->placement = $placement;
return $this; return $this;
} }