tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Removed Object::*_extension() non-LSB deprecation

Browse Source 
Its just a simplication, and unnecessarily complicates
module compatibilities.
This commit is contained in:
Ingo Schommer 2013-03-26 00:31:05 +01:00
parent 1916a6e8f4
commit 4ea98ae440
2 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
core/Object.php
View File

@ -426,12 +426,6 @@ abstract class Object {
public static function has_extension($requiredExtension) {
$class = get_called_class();
if(func_num_args() > 1) {
Deprecation::notice('3.2.0', "Object::has_extension() deprecated. Call has_extension() on the class");
$class = func_get_arg(0);
$requiredExtension = func_get_arg(1);
}
$requiredExtension = strtolower($requiredExtension);
$extensions = Config::inst()->get($class, 'extensions');
@ -459,12 +453,6 @@ abstract class Object {
public static function add_extension($extension) {
$class = get_called_class();
if(func_num_args() > 1) {
Deprecation::notice('3.2.0', "Object::add_extension() deprecated. Call add_extension() on the class");
$class = func_get_arg(0);
$extension = func_get_arg(1);
}
if(!preg_match('/^([^(]*)/', $extension, $matches)) {
return false;
}
@ -520,12 +508,6 @@ abstract class Object {
public static function remove_extension($extension) {
$class = get_called_class();
if(func_num_args() > 1) {
Deprecation::notice('3.2.0', "Object::remove_extension() deprecated. Call remove_extension() on the class");
$class = func_get_arg(0);
$extension = func_get_arg(1);
}
Config::inst()->remove($class, 'extensions', Config::anything(), $extension);
Config::inst()->extraConfigSourcesChanged($class);

1
docs/en/changelogs/3.1.0.md
View File

@ -342,7 +342,6 @@ you can enable those warnings and future-proof your code already.
* `TableListField`, `ComplexTableField`, `TableField`, `HasOneComplexTableField`, `HasManyComplexTableField` and `ManyManyComplexTableField` have been removed from the core and placed into a module called "legacytablefields" located at https://github.com/silverstripe-labs/legacytablefields
* `prototype.js` and `behaviour.js` have been removed from the core, they are no longer used. If you have custom code relying on these two libraries, please update your code to include the files yourself
* `Object::has_extension()` and `Object::add_extension()` deprecated in favour of using late static binding, please use `{class}::has_extension()` and `{class}::add_extension()` instead, where {class} is the class name of your DataObject class.
* Removed `SiteTree.MetaKeywords` since they are irrelevant in terms of SEO ([seomoz article](http://www.mattcutts.com/blog/keywords-meta-tag-in-web-search/)) and general page informancy
* Removed `SiteTree.MetaTitle` as a means to customize the window title, use `SiteTree.Title` instead
* Deprecated `Profiler` class, use third-party solutions like [xhprof](https://github.com/facebook/xhprof/)