From 4e567adec95f16d6a32c644680511bb263f07877 Mon Sep 17 00:00:00 2001 From: Ingo Schommer Date: Sat, 1 Nov 2008 19:05:16 +0000 Subject: [PATCH] ENHANCEMENT Using eval() in textcollector to test for valid PHP syntax git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65054 467b73ca-7a2a-4603-9d3b-597d59a354a9 --- core/i18nTextCollector.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core/i18nTextCollector.php b/core/i18nTextCollector.php index fa7de91ad..cb5824eb5 100644 --- a/core/i18nTextCollector.php +++ b/core/i18nTextCollector.php @@ -311,14 +311,15 @@ class i18nTextCollector extends Object { } // Open the English file and write the Master String Table - if($fh = fopen($langFolder . '/' . $this->defaultLocale . '.php', "w")) { + $langFile = $langFolder . '/' . $this->defaultLocale . '.php'; + if($fh = fopen($langFile, "w")) { if($entities) foreach($entities as $fullName => $spec) { $php .= $this->langArrayCodeForEntitySpec($fullName, $spec); } // test for valid PHP syntax by eval'ing it try{ - //eval($php); + eval($php); } catch(Exception $e) { user_error('i18nTextCollector->writeMasterStringFile(): Invalid PHP language file. Error: ' . $e->toString(), E_USER_ERROR); }