tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

FIX for #4909: Ensure RSSFeed_Entry is instantiated using the injector.

Browse Source
This commit is contained in:
Patrick Nelson 2016-01-22 13:29:44 -05:00
parent 5f82e40fd4
commit 4bd66b9d36
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
api/RSSFeed.php
View File

@ -149,7 +149,7 @@ class RSSFeed extends ViewableData {
if(isset($this->entries)) { if(isset($this->entries)) {
foreach($this->entries as $entry) { foreach($this->entries as $entry) {
$output->push( $output->push(
new RSSFeed_Entry($entry, $this->titleField, $this->descriptionField, $this->authorField)); RSSFeed_Entry::create($entry, $this->titleField, $this->descriptionField, $this->authorField));
} }
} }
return $output; return $output;
@ -184,7 +184,11 @@ class RSSFeed extends ViewableData {
} }
/** /**
* Output the feed to the browser * Output the feed to the browser.
*
* TODO: Pass $response object to ->outputToBrowser() to loosen dependence on global state for easier testing/prototyping so dev can inject custom SS_HTTPResponse instance.
*
* @return HTMLText
*/ */
public function outputToBrowser() { public function outputToBrowser() {
$prevState = Config::inst()->get('SSViewer', 'source_file_comments'); $prevState = Config::inst()->get('SSViewer', 'source_file_comments');