From 4b22ab4dfe8ee04e19d26f70d8fcbdbe92d81c06 Mon Sep 17 00:00:00 2001
From: Andrew Paxley <andrewandante@gmail.com>
Date: Mon, 19 Jun 2023 17:16:53 +1200
Subject: [PATCH] API deprecate InheritedPermissions::getJoinTable

---
 src/Security/InheritedPermissions.php | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/Security/InheritedPermissions.php b/src/Security/InheritedPermissions.php
index d961d11cd..9cd9dfd90 100644
--- a/src/Security/InheritedPermissions.php
+++ b/src/Security/InheritedPermissions.php
@@ -10,6 +10,7 @@ use SilverStripe\ORM\Hierarchy\Hierarchy;
 use SilverStripe\Versioned\Versioned;
 use Psr\SimpleCache\CacheInterface;
 use SilverStripe\Core\Cache\MemberCacheFlusher;
+use SilverStripe\Dev\Deprecation;
 
 /**
  * Calculates batch permissions for nested objects for:
@@ -48,7 +49,6 @@ class InheritedPermissions implements PermissionChecker, MemberCacheFlusher
     public const LOGGED_IN_USERS = 'LoggedInUsers';
 
     /**
-     * @TODO - rename this to ONLY_THESE_GROUPS
      * Restrict to specific groups
      */
     public const ONLY_THESE_USERS = 'OnlyTheseUsers';
@@ -642,11 +642,13 @@ class InheritedPermissions implements PermissionChecker, MemberCacheFlusher
      * Get join table for type
      * Defaults to those provided by {@see InheritedPermissionsExtension)
      *
+     * @deprecated 5.1.0 Use getGroupJoinTable() instead
      * @param string $type
      * @return string
      */
     protected function getJoinTable($type)
     {
+        Deprecation::notice('5.1.0', 'Use getGroupJoinTable() instead');
         return $this->getGroupJoinTable($type);
     }