tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

ENH store tableList in cache (#11183)

Browse Source
This commit is contained in:
Thomas Portelange 2024-03-26 00:03:46 +01:00 committed by GitHub
parent 164e2a18ab
commit 492cb800fa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 31 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
_config/cache.yml
View File

@ -46,3 +46,8 @@ SilverStripe\Core\Injector\Injector:
factory: SilverStripe\Core\Cache\CacheFactory factory: SilverStripe\Core\Cache\CacheFactory
constructor: constructor:
namespace: 'VersionProvider' namespace: 'VersionProvider'
Psr\SimpleCache\CacheInterface.ClassInfo:
factory: SilverStripe\Core\Cache\CacheFactory
constructor:
namespace: "ClassInfo"
disable-container: true

40
src/Core/ClassInfo.php
View File

@ -10,6 +10,9 @@ use SilverStripe\Core\Manifest\ClassLoader;
use SilverStripe\ORM\DataObject; use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\DB; use SilverStripe\ORM\DB;
use SilverStripe\View\ViewableData; use SilverStripe\View\ViewableData;
use Psr\SimpleCache\CacheInterface;
use SilverStripe\Core\Flushable;
use SilverStripe\Core\Injector\Injector;
/** /**
* Provides introspection information about the class tree. * Provides introspection information about the class tree.
@ -18,16 +21,8 @@ use SilverStripe\View\ViewableData;
* class introspection heavily and without the caching it creates an unfortunate * class introspection heavily and without the caching it creates an unfortunate
* performance hit. * performance hit.
*/ */
class ClassInfo class ClassInfo implements Flushable
{ {
/**
* Cache for {@link hasTable()}
*
* @internal
* @var array
*/
private static $_cache_all_tables = [];
/** /**
* @internal * @internal
* @var array Cache for {@link ancestry()}. * @var array Cache for {@link ancestry()}.
@ -82,24 +77,41 @@ class ClassInfo
} }
/** /**
* Cached call to see if the table exists in the DB.
* For live queries, use DBSchemaManager::hasTable.
* @param string $tableName * @param string $tableName
* @return bool * @return bool
*/ */
public static function hasTable($tableName) public static function hasTable($tableName)
{ {
// Cache the list of all table names to reduce on DB traffic $cache = self::getCache();
if (empty(self::$_cache_all_tables) && DB::is_active()) { $configData = serialize(DB::getConfig());
self::$_cache_all_tables = DB::get_schema()->tableList(); $cacheKey = 'tableList_' . md5($configData);
$tableList = $cache->get($cacheKey) ?? [];
if (empty($tableList) && DB::is_active()) {
$tableList = DB::get_schema()->tableList();
// Cache the list of all table names to reduce on DB traffic
$cache->set($cacheKey, $tableList);
} }
return !empty(self::$_cache_all_tables[strtolower($tableName)]); return !empty($tableList[strtolower($tableName)]);
}
private static function getCache(): CacheInterface
{
return Injector::inst()->get(CacheInterface::class . '.ClassInfo');
} }
public static function reset_db_cache() public static function reset_db_cache()
{ {
self::$_cache_all_tables = null; self::getCache()->clear();
self::$_cache_ancestry = []; self::$_cache_ancestry = [];
} }
public static function flush()
{
self::reset_db_cache();
}
/** /**
* Returns the manifest of all classes which are present in the database. * Returns the manifest of all classes which are present in the database.
* *