tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

ENH Cache DataObject::getSchema()

Browse Source
This commit is contained in:
Steve Boyd 2023-06-28 11:11:43 +12:00
parent 0c40cc9b3d
commit 46d7930489
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/ORM/DataObject.php
View File

@ -329,6 +329,14 @@ class DataObject extends ViewableData implements DataObjectInterface, i18nEntity
*/ */
private static $cascade_duplicates = []; private static $cascade_duplicates = [];
/**
* Used to cache the schema to prevent repeatedly fetching the singleton
* While this is a fast operation, in some scenarios getSchema() is called an extremely large number of times
*
* @internal
*/
private static ?DataObjectSchema $schema = null;
/** /**
* Get schema object * Get schema object
* *
@ -336,7 +344,10 @@ class DataObject extends ViewableData implements DataObjectInterface, i18nEntity
*/ */
public static function getSchema() public static function getSchema()
{ {
return Injector::inst()->get(DataObjectSchema::class); if (is_null(self::$schema)) {
self::$schema = Injector::inst()->get(DataObjectSchema::class);
}
return self::$schema;
} }
/** /**