tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

BUG Fixing ToggleField to work correctly with jQuery

Browse Source
This commit is contained in:
Sean Harvey 2012-11-16 11:33:58 +13:00
parent 77337ae58c
commit 4651e9bbc9
2 changed files with 15 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
forms/ToggleField.php
View File

@ -2,6 +2,8 @@
/** /**
* ReadonlyField with added toggle-capabilities - will preview the first sentence of the contained text-value, * ReadonlyField with added toggle-capabilities - will preview the first sentence of the contained text-value,
* and show the full content by a javascript-switch. * and show the full content by a javascript-switch.
*
* @deprecated 3.1 Use custom javascript with a ReadonlyField.
* *
* Caution: Strips HTML-encoding for the preview. * Caution: Strips HTML-encoding for the preview.
* @package forms * @package forms
@ -48,9 +50,8 @@ class ToggleField extends ReadonlyField {
public function Field($properties = array()) { public function Field($properties = array()) {
$content = ''; $content = '';
Requirements::javascript(FRAMEWORK_DIR . "/thirdparty/prototype/prototype.js"); Requirements::javascript(FRAMEWORK_DIR . '/thirdparty/jquery/jquery.js');
Requirements::javascript(FRAMEWORK_DIR . "/thirdparty/behaviour/behaviour.js");
Requirements::javascript(FRAMEWORK_DIR . "/javascript/ToggleField.js"); Requirements::javascript(FRAMEWORK_DIR . "/javascript/ToggleField.js");
if($this->startClosed) $this->addExtraClass('startClosed'); if($this->startClosed) $this->addExtraClass('startClosed');
@ -60,7 +61,7 @@ class ToggleField extends ReadonlyField {
if($this->charNum) $reducedVal = substr($rawInput,0,$this->charNum); if($this->charNum) $reducedVal = substr($rawInput,0,$this->charNum);
else $reducedVal = DBField::create_field('Text',$rawInput)->{$this->truncateMethod}(); else $reducedVal = DBField::create_field('Text',$rawInput)->{$this->truncateMethod}();
// only create togglefield if the truncated content is shorter // only create togglefield if the truncated content is shorter
if(strlen($reducedVal) < strlen($rawInput)) { if(strlen($reducedVal) < strlen($rawInput)) {
$content = <<<HTML $content = <<<HTML

43
javascript/ToggleField.js
View File

@ -1,35 +1,12 @@
// Shortcut-function (until we update to Prototye v1.5) var field = $('div.toggleField');
if(typeof $$ != "Function") $$ = document.getElementsBySelector;
var ToggleField = Class.create(); if(field.hasClass('startClosed')) {
ToggleField.prototype = { field.find('div.contentMore').hide();
initialize: function() { field.find('div.contentLess').show();
var rules = {};
rules['#' + this.id + ' .triggerMore'] = {
onclick: function(e) {
Element.toggle(this);
Event.stop(e); return false;
}.bind(this)
};
rules['#' + this.id + ' .triggerLess'] = {
onclick: function(e) {
Element.toggle(this);
Event.stop(e); return false;
}.bind(this)
};
Behaviour.register(rules);
if(Element.hasClassName(this, 'startClosed')) {
Element.toggle(this);
}
},
toggle: function() {
var lessDivs = $$('#' + this.id + ' .contentLess');
if(lessDivs) Element.toggle(lessDivs[0]);
var moreDivs = $$('#' + this.id + ' .contentMore');
if(moreDivs) Element.toggle(moreDivs[0]);
}
} }
ToggleField.applyTo('div.toggleField');
$('div.toggleField .triggerLess, div.toggleField .triggerMore').click(function() {
field.find('div.contentMore').toggle();
field.find('div.contentLess').toggle();
});