mirror of
https://github.com/silverstripe/silverstripe-framework
synced 2024-10-22 14:05:37 +02:00
Merge pull request #4454 from tractorcow/pulls/3.2/dbid-semver
BUG Fix semver violation in create_table_options
This commit is contained in:
commit
4373c8716b
@ -12,25 +12,13 @@ class MySQLSchemaManager extends DBSchemaManager {
|
|||||||
* Identifier for this schema, used for configuring schema-specific table
|
* Identifier for this schema, used for configuring schema-specific table
|
||||||
* creation options
|
* creation options
|
||||||
*/
|
*/
|
||||||
const ID = 'MySQL';
|
const ID = 'MySQLDatabase';
|
||||||
|
|
||||||
public function createTable($table, $fields = null, $indexes = null, $options = null, $advancedOptions = null) {
|
public function createTable($table, $fields = null, $indexes = null, $options = null, $advancedOptions = null) {
|
||||||
$fieldSchemas = $indexSchemas = "";
|
$fieldSchemas = $indexSchemas = "";
|
||||||
|
|
||||||
if (!empty($options[self::ID])) {
|
if (!empty($options[self::ID])) {
|
||||||
$addOptions = $options[self::ID];
|
$addOptions = $options[self::ID];
|
||||||
} elseif (!empty($options[get_class($this)])) {
|
|
||||||
Deprecation::notice(
|
|
||||||
'3.2',
|
|
||||||
'Use MySQLSchemaManager::ID for referencing mysql-specific table creation options'
|
|
||||||
);
|
|
||||||
$addOptions = $options[get_class($this)];
|
|
||||||
} elseif (!empty($options[get_parent_class($this)])) {
|
|
||||||
Deprecation::notice(
|
|
||||||
'3.2',
|
|
||||||
'Use MySQLSchemaManager::ID for referencing mysql-specific table creation options'
|
|
||||||
);
|
|
||||||
$addOptions = $options[get_parent_class($this)];
|
|
||||||
} else {
|
} else {
|
||||||
$addOptions = "ENGINE=InnoDB";
|
$addOptions = "ENGINE=InnoDB";
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user