From 425f5d278ce0f97f130b8cc31372ab42a20ca59b Mon Sep 17 00:00:00 2001
From: Sam Minnee <sam@silverstripe.com>
Date: Thu, 15 Oct 2009 22:21:41 +0000
Subject: [PATCH] MINOR: Hide readonly permission group fields on pages when
 not relevant, as they are confusing. (from r88019)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89178 467b73ca-7a2a-4603-9d3b-597d59a354a9
---
 core/model/SiteTree.php | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/core/model/SiteTree.php b/core/model/SiteTree.php
index 0964c564d..8d3917a41 100755
--- a/core/model/SiteTree.php
+++ b/core/model/SiteTree.php
@@ -1665,9 +1665,18 @@ class SiteTree extends DataObject implements PermissionProvider,i18nEntityProvid
 
 		if(!Permission::check('SITETREE_GRANT_ACCESS')) {
 			$fields->makeFieldReadonly($viewersOptionsField);
-			$fields->makeFieldReadonly($viewerGroupsField);
+			if($this->CanViewType == 'OnlyTheseUsers') {
+				$fields->makeFieldReadonly($viewerGroupsField);
+			} else {
+				$fields->removeByName('ViewerGroups');
+			}
+			
 			$fields->makeFieldReadonly($editorsOptionsField);
-			$fields->makeFieldReadonly($editorGroupsField);
+			if($this->CanEditType == 'OnlyTheseUsers') {
+				$fields->makeFieldReadonly($editorGroupsField);
+			} else {
+				$fields->removeByName('EditorGroups');
+			}
 		}
 		
 		$tabContent->setTitle(_t('SiteTree.TABCONTENT', "Content"));